Re: [PATCH v2 02/10] dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit adds the compatible string `qcom,msm8960-sps-sic` for an Interrupt Controller but fails to define and require standard interrupt controller properties.
--

commit 4920dc5889f6c452e2f9cb09ecf073afa3b06d47
Author: Antony Kurniawan Soemardi <linux@smankusors.com>

dt-bindings: mfd: syscon: add qcom,msm8960-sps-sic

This commit adds the compatible string for the Smart Peripheral System
Interrupt Controller present on the Qualcomm MSM8960 SoC to the syscon
bindings.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
[ ... ]
> @@ -219,6 +220,7 @@ properties:
>                - nxp,s32g3-gpr
>                - qcom,apq8064-mmss-sfpb
>                - qcom,apq8064-sps-sic
> +              - qcom,msm8960-sps-sic
>                - rockchip,px30-qos

Could this cause a regression in schema validation completeness? The commit
message notes this represents an interrupt controller, but the corresponding
standard properties are missing.

Should the binding also define and require interrupt-controller and
#interrupt-cells with appropriate constraints?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-msm8960-wifi-v2-0-7cbae45dab5e@smankusors.com?part=2