Re: [PATCH v2 08/10] ARM: dts: qcom: msm8960: add SMSM & SPS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `sps_sic_non_secure` node is named `interrupt-controller@12100000` but lacks the required `interrupt-controller` property.
- [Low] The newly added `smsm` node uses deprecated `qcom,ipc-X` properties.
--

commit 8d6a970313bb462414684a54e064e3c213cf7869
Author: Antony Kurniawan Soemardi <linux@smankusors.com>

ARM: dts: qcom: msm8960: add SMSM & SPS

This commit adds the Shared Memory State Machine node to coordinate state
transitions between the Applications processor and the Riva subsystem. It also
adds the SPS SIC non-secure node.

> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index e215d8809f288..fdc060df45449 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -109,6 +109,31 @@ smem {
>  		hwlocks = <&sfpb_mutex 3>;
>  	};
>  
> +	smsm {
> +		compatible = "qcom,smsm";
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		qcom,ipc-1 = <&l2cc 8 4>;
> +		qcom,ipc-2 = <&l2cc 8 14>;
> +		qcom,ipc-3 = <&l2cc 8 23>;
> +		qcom,ipc-4 = <&sps_sic_non_secure 0x4094 0>;

This isn't a bug, but the device tree binding schema for qcom,smsm marks
qcom,ipc-1 through qcom,ipc-4 as deprecated.

Is it possible to use the modern mboxes property here instead to model
the cross-processor hardware signaling?

[ ... ]

> @@ -459,6 +484,11 @@ clock-controller@4000000 {
>  				      "hdmipll";
>  		};
>  
> +		sps_sic_non_secure: interrupt-controller@12100000 {

Since this node lacks the interrupt-controller property and acts as a syscon,
naming it interrupt-controller@12100000 will trigger dtbs_check warnings.

Should this be renamed to a generic name like syscon@12100000?

> +			compatible = "qcom,msm8960-sps-sic", "syscon";
> +			reg = <0x12100000 0x10000>;
> +		};
> +
>  		sdcc3: mmc@12180000 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-msm8960-wifi-v2-0-7cbae45dab5e@smankusors.com?part=8