Re: [PATCH v5 2/3] arm64: dts: qcom: Add Eliza-specific PM7550BA dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Duplication of the entire PM7550BA PMIC Device Tree Include file to change the parent bus.
--

commit 5c503019cfe9b06711f49ae8a17f64175ea5c01d
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: Add Eliza-specific PM7550BA dtsi

This commit introduces a new Eliza-specific dtsi file for the PM7550BA PMIC.
It addresses hardware differences in the SPMI bus layout on the Eliza platform
by duplicating the PMIC definitions and placing them under spmi_bus0.

> The existing PM7550BA dtsi does not provide a way to describe this,
> so introduce an Eliza-specific variant with the appropriate bus
> configuration.
> 
> This duplication is required due to hardware differences in how the
> SPMI bus is exposed on this platform.

Is this duplication strictly required? While this isn't a bug, it seems
possible to avoid duplicating the file just to change the parent bus.

> diff --git a/arch/arm64/boot/dts/qcom/pm7550ba-eliza.dtsi b/arch/arm64/boot/dts/qcom/pm7550ba-eliza.dtsi
> new file mode 100644
> index 0000000000000..18692893ca418
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm7550ba-eliza.dtsi
> @@ -0,0 +1,70 @@
[ ... ]
> +&spmi_bus0 {
> +	pm7550ba: pmic@7 {
> +		compatible = "qcom,pm7550ba", "qcom,spmi-pmic";
> +		reg = <7 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		pm7550ba_temp_alarm: temp-alarm@a00 {

Could the common PMIC properties and sub-nodes be extracted into a shared
dtsi file using node appending?

If the shared file appended these thermal and GPIO definitions to an existing
pm7550ba label, the individual board files could define the empty base node
under their respective bus (such as spmi_bus0) and then include the shared
file.

Would this help prevent future maintenance issues when thermal trips or GPIO
definitions need to be synchronized across platforms?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-eliza-adsp-usb-v5-0-a21056ffd892@oss.qualcomm.com?part=2