Re: [PATCH v5 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string 'qcom,eliza-pmic-glink' is used in the device tree but is not documented in the YAML bindings.
--

commit b9c08b3ae54cc2b9b02f4c789a987a560f3a9531
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support

This commit enables USB and ADSP support for the Eliza MTP by describing the
USB Type-C port and eUSB2 repeater. It also enables the USB controller, PHYs,
and the ADSP remoteproc.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index 90f629800cb02..3e41c95edb28f 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts

[ ... ]

> @@ -54,6 +57,44 @@ bi_tcxo_ao_div2: bi-tcxo-ao-div2-clk {
>  		};
>  	};
>  
> +	pmic-glink {
> +		compatible = "qcom,eliza-pmic-glink",
> +			     "qcom,sm8550-pmic-glink",
> +			     "qcom,pmic-glink";

Is the "qcom,eliza-pmic-glink" compatible string documented in the YAML
bindings?

It appears to be missing from the
Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml schema.
Will this cause validation to fail when running dtbs_check?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-eliza-adsp-usb-v5-0-a21056ffd892@oss.qualcomm.com?part=3