* [PATCH net] net: ag71xx: check error for platform_get_irq
@ 2026-05-15 0:59 Rosen Penev
2026-05-15 7:21 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-05-15 0:59 UTC (permalink / raw)
To: netdev
Cc: Chris Snook, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Oleksij Rempel, open list
Exit probe if the proper IRQ cannot be found.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/atheros/ag71xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index a5ab99474179..4e4794c4dfdc 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1856,6 +1856,9 @@ static int ag71xx_probe(struct platform_device *pdev)
ag71xx_int_disable(ag, AG71XX_INT_POLL);
ndev->irq = platform_get_irq(pdev, 0);
+ if (ndev->irq < 0)
+ return ndev->irq;
+
err = devm_request_irq(&pdev->dev, ndev->irq, ag71xx_interrupt,
0x0, dev_name(&pdev->dev), ndev);
if (err) {
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: ag71xx: check error for platform_get_irq
2026-05-15 0:59 [PATCH net] net: ag71xx: check error for platform_get_irq Rosen Penev
@ 2026-05-15 7:21 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2026-05-15 7:21 UTC (permalink / raw)
To: Rosen Penev, netdev
Cc: LKML, Andrew Lunn, Chris Snook, David S. Miller, Eric Dumazet,
Jakub Kicinski, Oleksij Rempel, Paolo Abeni
> Exit probe if the proper IRQ cannot be found.
Would a summary phrase like “Complete error handling for a failed platform_get_irq() call”
be nicer?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-15 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 0:59 [PATCH net] net: ag71xx: check error for platform_get_irq Rosen Penev
2026-05-15 7:21 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.