[PATCH 1/2] dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H

[PATCH 1/2] dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H

[Dario Binacchi]

Add dt-bindings for 10.1" TFT LCD module from Ampire Co. Ltd.
as part of panel-simple.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 3e41ed0ef5d5..ea5fe23a6fe8 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -29,6 +29,8 @@ properties:
     # compatible must be listed in alphabetical order, ordered by compatible.
     # The description in the comment is mandatory for each compatible.
 
+        # Ampire AM-1280800W8TZQW-T00H 10.1" WQVGA TFT LCD panel
+      - ampire,am-1280800w8tzqw-t00h
         # Ampire AM-1280800N3TZQW-T00H 10.1" WQVGA TFT LCD panel
       - ampire,am-1280800n3tzqw-t00h
         # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
-- 
2.43.0

base-commit: 70eda68668d1476b459b64e69b8f36659fa9dfa8
branch: am-1280800N3tzqw-to00h

[PATCH 2/2] drm/panel: simple: Add AM-1280800W8TZQW-T00H

[Dario Binacchi]

Add Ampire, AM-1280800W8TZQW-T00H 10.1" TFT LCD panel timings.

Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 236bd56208cc..99deab68a2fb 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -794,6 +794,31 @@ static void panel_simple_remove(struct device *dev)
 		put_device(&panel->ddc->dev);
 }
 
+static const struct drm_display_mode ampire_am_1280800w8tzqw_t00h_mode = {
+	.clock = 72400,
+	.hdisplay = 1280,
+	.hsync_start = 1280 + 40,
+	.hsync_end = 1280 + 40 + 80,
+	.htotal = 1280 + 40 + 80 + 40,
+	.vdisplay = 800,
+	.vsync_start = 800 + 10,
+	.vsync_end = 800 + 10 + 18,
+	.vtotal = 800 + 10 + 18 + 10,
+};
+
+static const struct panel_desc ampire_am_1280800w8tzqw_t00h = {
+	.modes = &ampire_am_1280800w8tzqw_t00h_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 217,
+		.height = 136,
+	},
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {
 	.clock = 71100,
 	.hdisplay = 1280,
@@ -5193,6 +5218,9 @@ static const struct of_device_id platform_of_match[] = {
 	{
 		.compatible = "ampire,am-1280800n3tzqw-t00h",
 		.data = &ampire_am_1280800n3tzqw_t00h,
+	}, {
+		.compatible = "ampire,am-1280800w8tzqw-t00h",
+		.data = &ampire_am_1280800w8tzqw_t00h,
 	}, {
 		.compatible = "ampire,am-480272h3tmqw-t01h",
 		.data = &ampire_am_480272h3tmqw_t01h,
-- 
2.43.0

base-commit: 70eda68668d1476b459b64e69b8f36659fa9dfa8
branch: am-1280800N3tzqw-to00h

Re: [PATCH 1/2] dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The new compatible string is not inserted in alphabetical order.
- [Low] The panel description comment incorrectly states the resolution as WQVGA.
--

commit bf39295cb05fc88a5c9fc03f7444ba1eb3e26cfc
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>

dt-bindings: display: simple: Add AM-1280800W8TZQW-T00H

This commit adds dt-bindings for a 10.1" TFT LCD module from Ampire Co. Ltd.
to the panel-simple binding.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3e41ed0ef5d51..ea5fe23a6fe84 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -29,6 +29,8 @@ properties:
>      # compatible must be listed in alphabetical order, ordered by compatible.
>      # The description in the comment is mandatory for each compatible.
>  
> +        # Ampire AM-1280800W8TZQW-T00H 10.1" WQVGA TFT LCD panel

This isn't a bug, but is the WQVGA description accurate here? The part number
AM-1280800 suggests a 1280x800 resolution (WXGA), while WQVGA is typically
480x272. It looks like this might have been copied from another entry.

> +      - ampire,am-1280800w8tzqw-t00h
>          # Ampire AM-1280800N3TZQW-T00H 10.1" WQVGA TFT LCD panel
>        - ampire,am-1280800n3tzqw-t00h

This isn't a bug, but should this new compatible be placed after
ampire,am-1280800n3tzqw-t00h? The comment above requires compatibles to be
listed in alphabetical order, and w comes after n.

>          # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515064721.1750990-1-dario.binacchi@amarulasolutions.com?part=1