From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V4 12/17] i3c: mipi-i3c-hci: Factor out reset-and-restore helper
Date: Fri, 15 May 2026 19:26:16 +0300 [thread overview]
Message-ID: <20260515162621.57719-13-adrian.hunter@intel.com> (raw)
In-Reply-To: <20260515162621.57719-1-adrian.hunter@intel.com>
Factor the reset-and-restore sequence out of i3c_hci_rpm_resume() into
a separate helper.
This allows the same logic to be reused for recovery paths in subsequent
changes without duplicating suspend/resume handling.
No functional change.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
Changes in V4:
Add Frank's Rev'd by
Changes in V3:
None
Changes in V2:
Drop redundant i3c_hci_sync_irq_inactive(hci)
from i3c_hci_reset_and_restore() because it is called by
hci->io->suspend() anyway
drivers/i3c/master/mipi-i3c-hci/core.c | 19 +++++++++++++++++--
drivers/i3c/master/mipi-i3c-hci/hci.h | 2 ++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
index 8274c84b16be..12a0122fb709 100644
--- a/drivers/i3c/master/mipi-i3c-hci/core.c
+++ b/drivers/i3c/master/mipi-i3c-hci/core.c
@@ -798,9 +798,8 @@ int i3c_hci_rpm_suspend(struct device *dev)
}
EXPORT_SYMBOL_GPL(i3c_hci_rpm_suspend);
-int i3c_hci_rpm_resume(struct device *dev)
+static int i3c_hci_do_reset_and_restore(struct i3c_hci *hci)
{
- struct i3c_hci *hci = dev_get_drvdata(dev);
int ret;
ret = i3c_hci_reset_and_init(hci);
@@ -821,6 +820,22 @@ int i3c_hci_rpm_resume(struct device *dev)
return 0;
}
+
+int i3c_hci_reset_and_restore(struct i3c_hci *hci)
+{
+ i3c_hci_bus_disable(hci);
+
+ hci->io->suspend(hci);
+
+ return i3c_hci_do_reset_and_restore(hci);
+}
+
+int i3c_hci_rpm_resume(struct device *dev)
+{
+ struct i3c_hci *hci = dev_get_drvdata(dev);
+
+ return i3c_hci_do_reset_and_restore(hci);
+}
EXPORT_SYMBOL_GPL(i3c_hci_rpm_resume);
static int i3c_hci_runtime_suspend(struct device *dev)
diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h
index 97c31a315a6e..a3151c26827e 100644
--- a/drivers/i3c/master/mipi-i3c-hci/hci.h
+++ b/drivers/i3c/master/mipi-i3c-hci/hci.h
@@ -175,4 +175,6 @@ int i3c_hci_process_xfer(struct i3c_hci *hci, struct hci_xfer *xfer, int n);
int i3c_hci_rpm_suspend(struct device *dev);
int i3c_hci_rpm_resume(struct device *dev);
+int i3c_hci_reset_and_restore(struct i3c_hci *hci);
+
#endif
--
2.51.0
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V4 12/17] i3c: mipi-i3c-hci: Factor out reset-and-restore helper
Date: Fri, 15 May 2026 19:26:16 +0300 [thread overview]
Message-ID: <20260515162621.57719-13-adrian.hunter@intel.com> (raw)
In-Reply-To: <20260515162621.57719-1-adrian.hunter@intel.com>
Factor the reset-and-restore sequence out of i3c_hci_rpm_resume() into
a separate helper.
This allows the same logic to be reused for recovery paths in subsequent
changes without duplicating suspend/resume handling.
No functional change.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
Changes in V4:
Add Frank's Rev'd by
Changes in V3:
None
Changes in V2:
Drop redundant i3c_hci_sync_irq_inactive(hci)
from i3c_hci_reset_and_restore() because it is called by
hci->io->suspend() anyway
drivers/i3c/master/mipi-i3c-hci/core.c | 19 +++++++++++++++++--
drivers/i3c/master/mipi-i3c-hci/hci.h | 2 ++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
index 8274c84b16be..12a0122fb709 100644
--- a/drivers/i3c/master/mipi-i3c-hci/core.c
+++ b/drivers/i3c/master/mipi-i3c-hci/core.c
@@ -798,9 +798,8 @@ int i3c_hci_rpm_suspend(struct device *dev)
}
EXPORT_SYMBOL_GPL(i3c_hci_rpm_suspend);
-int i3c_hci_rpm_resume(struct device *dev)
+static int i3c_hci_do_reset_and_restore(struct i3c_hci *hci)
{
- struct i3c_hci *hci = dev_get_drvdata(dev);
int ret;
ret = i3c_hci_reset_and_init(hci);
@@ -821,6 +820,22 @@ int i3c_hci_rpm_resume(struct device *dev)
return 0;
}
+
+int i3c_hci_reset_and_restore(struct i3c_hci *hci)
+{
+ i3c_hci_bus_disable(hci);
+
+ hci->io->suspend(hci);
+
+ return i3c_hci_do_reset_and_restore(hci);
+}
+
+int i3c_hci_rpm_resume(struct device *dev)
+{
+ struct i3c_hci *hci = dev_get_drvdata(dev);
+
+ return i3c_hci_do_reset_and_restore(hci);
+}
EXPORT_SYMBOL_GPL(i3c_hci_rpm_resume);
static int i3c_hci_runtime_suspend(struct device *dev)
diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h
index 97c31a315a6e..a3151c26827e 100644
--- a/drivers/i3c/master/mipi-i3c-hci/hci.h
+++ b/drivers/i3c/master/mipi-i3c-hci/hci.h
@@ -175,4 +175,6 @@ int i3c_hci_process_xfer(struct i3c_hci *hci, struct hci_xfer *xfer, int n);
int i3c_hci_rpm_suspend(struct device *dev);
int i3c_hci_rpm_resume(struct device *dev);
+int i3c_hci_reset_and_restore(struct i3c_hci *hci);
+
#endif
--
2.51.0
next prev parent reply other threads:[~2026-05-15 16:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 16:26 [PATCH V4 00/17] i3c: mipi-i3c-hci: DMA abort, recovery and related improvements Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 01/17] i3c: mipi-i3c-hci: Fix suspend behavior when bus disable falls back to software reset Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 02/17] i3c: mipi-i3c-hci: Preserve RUN bit when aborting DMA ring Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 03/17] i3c: mipi-i3c-hci: Prevent DMA enqueue while ring is aborting or in error Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 04/17] i3c: mipi-i3c-hci: Wait for DMA ring restart to complete Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 05/17] i3c: mipi-i3c-hci: Move hci_dma_xfer_done() definition Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 06/17] i3c: mipi-i3c-hci: Call hci_dma_xfer_done() from dequeue path Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 07/17] i3c: mipi-i3c-hci: Complete transfer lists immediately on error Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 08/17] i3c: mipi-i3c-hci: Avoid restarting DMA ring after aborting wrong transfer Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 09/17] i3c: mipi-i3c-hci: Add DMA ring abort/reset quirk for Intel controllers Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 10/17] i3c: mipi-i3c-hci: Factor out hci_dma_abort() Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 11/17] i3c: mipi-i3c-hci: Add DMA ring abort quirk for Intel controllers Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter [this message]
2026-05-15 16:26 ` [PATCH V4 12/17] i3c: mipi-i3c-hci: Factor out reset-and-restore helper Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 13/17] i3c: mipi-i3c-hci: Add DMA-mode recovery for internal controller errors Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 14/17] i3c: mipi-i3c-hci: Wait for NoOp commands to complete Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 15/17] i3c: mipi-i3c-hci: Base timeouts on actual transfer start time Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 16/17] i3c: mipi-i3c-hci: Consolidate DMA ring allocation Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 17/17] i3c: mipi-i3c-hci: Increase DMA transfer ring size to maximum Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515162621.57719-13-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.