From: Jonathan Cameron <jic23@kernel.org>
To: Pramod Maurya <pramod.nexgen@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/3] staging: axis-fifo: Fix alignment of wait_event_interruptible arguments
Date: Sat, 16 May 2026 12:20:22 +0100 [thread overview]
Message-ID: <20260516122022.1aa82a8a@jic23-huawei> (raw)
In-Reply-To: <20260515075736.172172-3-pramod.nexgen@gmail.com>
On Fri, 15 May 2026 03:57:35 -0400
Pramod Maurya <pramod.nexgen@gmail.com> wrote:
> The second argument to wait_event_interruptible() was indented with a
> single tab instead of being aligned to the opening parenthesis. Since
> the fully-aligned form exceeds 80 columns, break the condition at the
> comparison operator and align the continuation line to the opening
> parenthesis.
>
> Fixes the following checkpatch.pl warning:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
It's not a related cleanup as nothing to do with DT - so break it out of the series
and send it separately.
Jonathan
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870ea9..1c34de020cf8 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> mutex_lock(&fifo->write_lock);
>
> ret = wait_event_interruptible(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
> + words_to_write);
> if (ret)
> goto end_unlock;
> }
next prev parent reply other threads:[~2026-05-16 11:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 8:32 [PATCH v3] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema Pramod Maurya
2026-05-10 9:43 ` Rob Herring (Arm)
2026-05-10 12:01 ` Pramod Maurya
2026-05-11 16:15 ` Jonathan Cameron
2026-05-11 16:24 ` David Lechner
2026-05-12 12:14 ` Rob Herring
2026-05-12 13:58 ` David Lechner
2026-05-12 14:10 ` Michal Simek
2026-05-12 14:16 ` David Lechner
2026-05-12 14:21 ` Michal Simek
2026-05-12 14:13 ` David Lechner
2026-05-12 19:42 ` Rob Herring
2026-05-12 20:03 ` David Lechner
2026-05-12 20:48 ` Rob Herring
2026-05-11 16:17 ` Jonathan Cameron
2026-05-11 20:55 ` sashiko-bot
2026-05-11 20:32 ` sashiko-bot
2026-05-15 7:57 ` [PATCH v4 0/3] Convert Xilinx XADC binding to YAML and related cleanups Pramod Maurya
2026-05-15 7:57 ` [PATCH v4 1/3] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema Pramod Maurya
2026-05-15 8:07 ` sashiko-bot
2026-05-16 11:18 ` Jonathan Cameron
2026-05-15 7:57 ` [PATCH v4 2/3] staging: axis-fifo: Fix alignment of wait_event_interruptible arguments Pramod Maurya
2026-05-15 8:17 ` sashiko-bot
2026-05-16 11:20 ` Jonathan Cameron [this message]
2026-05-15 7:57 ` [PATCH v4 3/3] dt-bindings: misc: Add binding for Xilinx AXI-Stream FIFO Pramod Maurya
2026-05-15 8:32 ` sashiko-bot
2026-05-15 11:03 ` Krzysztof Kozlowski
2026-05-16 11:08 ` [PATCH v4 0/3] Convert Xilinx XADC binding to YAML and related cleanups Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516122022.1aa82a8a@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.nexgen@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.