All of lore.kernel.org
 help / color / mirror / Atom feed
* [android-common:android15-6.6-2025-05 0/5] include/linux/blk-mq.h:865:31: sparse: sparse: unsigned value that used to be signed checked against zero?
@ 2026-05-16  9:39 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-05-16  9:39 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "low confidence static check warning: include/linux/blk-mq.h:865:31: sparse: sparse: unsigned value that used to be signed checked against zero?"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com

tree:   https://android.googlesource.com/kernel/common android15-6.6-2025-05
head:   69e9e5ccddbc3e3bc5614ab8465b6fcd8fafd443
commit: 99ca540851ee906ae15d36566ed3447e6e415780 [0/5] block: cleanup and fix batch completion adding conditions
:::::: branch date: 5 days ago
:::::: commit date: 1 year, 3 months ago
config: i386-randconfig-062-20260516 (https://download.01.org/0day-ci/archive/20260516/202605161755.Z2bS6Oi4-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260516/202605161755.Z2bS6Oi4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202605161755.Z2bS6Oi4-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   drivers/block/null_blk/main.c: note: in included file (through drivers/block/null_blk/null_blk.h):
>> include/linux/blk-mq.h:865:31: sparse: sparse: unsigned value that used to be signed checked against zero?
   drivers/block/null_blk/main.c:1677:46: sparse: signed value source

vim +865 include/linux/blk-mq.h

99e48cd6855e953 John Garry 2022-07-06  842  
f794f3351f2672d Jens Axboe 2021-10-08  843  /*
f794f3351f2672d Jens Axboe 2021-10-08  844   * Batched completions only work when there is no I/O error and no special
f794f3351f2672d Jens Axboe 2021-10-08  845   * ->end_io handler.
f794f3351f2672d Jens Axboe 2021-10-08  846   */
f794f3351f2672d Jens Axboe 2021-10-08  847  static inline bool blk_mq_add_to_batch(struct request *req,
f794f3351f2672d Jens Axboe 2021-10-08  848  				       struct io_comp_batch *iob, int ioerror,
f794f3351f2672d Jens Axboe 2021-10-08  849  				       void (*complete)(struct io_comp_batch *))
f794f3351f2672d Jens Axboe 2021-10-08  850  {
c6b7a3a26e809c9 Ming Lei   2023-06-24  851  	/*
99ca540851ee906 Jens Axboe 2025-02-13  852  	 * Check various conditions that exclude batch processing:
99ca540851ee906 Jens Axboe 2025-02-13  853  	 * 1) No batch container
99ca540851ee906 Jens Axboe 2025-02-13  854  	 * 2) Has scheduler data attached
99ca540851ee906 Jens Axboe 2025-02-13  855  	 * 3) Not a passthrough request and end_io set
99ca540851ee906 Jens Axboe 2025-02-13  856  	 * 4) Not a passthrough request and an ioerror
c6b7a3a26e809c9 Ming Lei   2023-06-24  857  	 */
99ca540851ee906 Jens Axboe 2025-02-13  858  	if (!iob)
f794f3351f2672d Jens Axboe 2021-10-08  859  		return false;
99ca540851ee906 Jens Axboe 2025-02-13  860  	if (req->rq_flags & RQF_SCHED_TAGS)
99ca540851ee906 Jens Axboe 2025-02-13  861  		return false;
99ca540851ee906 Jens Axboe 2025-02-13  862  	if (!blk_rq_is_passthrough(req)) {
99ca540851ee906 Jens Axboe 2025-02-13  863  		if (req->end_io)
99ca540851ee906 Jens Axboe 2025-02-13  864  			return false;
99ca540851ee906 Jens Axboe 2025-02-13 @865  		if (ioerror < 0)
99ca540851ee906 Jens Axboe 2025-02-13  866  			return false;
99ca540851ee906 Jens Axboe 2025-02-13  867  	}
ab3e1d3bbab9e97 Jens Axboe 2022-09-21  868  
f794f3351f2672d Jens Axboe 2021-10-08  869  	if (!iob->complete)
f794f3351f2672d Jens Axboe 2021-10-08  870  		iob->complete = complete;
f794f3351f2672d Jens Axboe 2021-10-08  871  	else if (iob->complete != complete)
f794f3351f2672d Jens Axboe 2021-10-08  872  		return false;
f794f3351f2672d Jens Axboe 2021-10-08  873  	iob->need_ts |= blk_mq_need_time_stamp(req);
f794f3351f2672d Jens Axboe 2021-10-08  874  	rq_list_add(&iob->req_list, req);
f794f3351f2672d Jens Axboe 2021-10-08  875  	return true;
f794f3351f2672d Jens Axboe 2021-10-08  876  }
320ae51feed5c2f Jens Axboe 2013-10-24  877  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-05-16  9:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-16  9:39 [android-common:android15-6.6-2025-05 0/5] include/linux/blk-mq.h:865:31: sparse: sparse: unsigned value that used to be signed checked against zero? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.