* [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL
@ 2026-05-14 9:20 Markus Stockhausen
2026-05-16 10:11 ` kernel test robot
2026-05-16 11:58 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Markus Stockhausen @ 2026-05-14 9:20 UTC (permalink / raw)
To: wsa+renesas, andi.shyti, linusw, brgl, linux-i2c, linux-gpio
Cc: Markus Stockhausen
Preface: I'm neither an I2C nor a GPIO expert. Instead of writing
a minimalistic driver for a special use case I was asked to enhance
an existing one. That might have many use cases I'm not aware of.
Feedback with clear directions is appreciated.
Some lower end hardware (especially Realtek based switches) are
designed with multiple I2C busses that share a single clock line.
E.g. the D-Link DGS-1250-28X realizes 4 I2C SFP busses with 5 gpios.
Enhance the i2c-gpio driver so it can handle such hardware designs.
- Detect GPIOs that are used by multiple I2C busses in the dts
by using a unique identifier for each managed SCL.
- The first probing instance allocates and requests the shared SCL
GPIO plus an associated mutex. Subsequent instances detect the
existing entry via the unique ID and increment a reference count
to reuse the descriptor.
- All data transfers are synchronized with the mutex before and
after transmission.
Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
---
v0 -> v1
- Initially this enhancement was submitted as a new driver with
a new devicetree structure. After some discussion Wolfram
advised to make only an enhancement to the i2c-gpio driver.
v0: https://lore.kernel.org/linux-i2c/20260511162528.84508-1-markus.stockhausen@gmx.de/
---
drivers/i2c/busses/i2c-gpio.c | 161 ++++++++++++++++++++++++++++++++--
1 file changed, 153 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index f4355b17bfbf..cdf863af2f1a 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -18,9 +18,23 @@
#include <linux/property.h>
#include <linux/slab.h>
+static LIST_HEAD(i2c_gpio_scl_list);
+static DEFINE_MUTEX(i2c_gpio_scl_list_lock);
+
+struct i2c_gpio_scl_data {
+ struct fwnode_handle *fw_node;
+ u32 fw_pin;
+ u32 fw_flags;
+ struct gpio_desc *gpio;
+ struct mutex lock;
+ refcount_t ref;
+ struct list_head list;
+ bool valid;
+};
+
struct i2c_gpio_private_data {
struct gpio_desc *sda;
- struct gpio_desc *scl;
+ struct i2c_gpio_scl_data *scl;
struct i2c_adapter adap;
struct i2c_algo_bit_data bit_data;
struct i2c_gpio_platform_data pdata;
@@ -31,6 +45,11 @@ struct i2c_gpio_private_data {
#endif
};
+static inline struct i2c_gpio_private_data *adap_to_priv(struct i2c_adapter *adap)
+{
+ return container_of(adap, struct i2c_gpio_private_data, adap);
+}
+
/*
* Toggle SDA by changing the output value of the pin. This is only
* valid for pins configured as open drain (i.e. setting the value
@@ -53,7 +72,7 @@ static void i2c_gpio_setscl_val(void *data, int state)
{
struct i2c_gpio_private_data *priv = data;
- gpiod_set_value_cansleep(priv->scl, state);
+ gpiod_set_value_cansleep(priv->scl->gpio, state);
}
static int i2c_gpio_getsda(void *data)
@@ -67,7 +86,17 @@ static int i2c_gpio_getscl(void *data)
{
struct i2c_gpio_private_data *priv = data;
- return gpiod_get_value_cansleep(priv->scl);
+ return gpiod_get_value_cansleep(priv->scl->gpio);
+}
+
+static int i2c_gpio_pre_xfer(struct i2c_adapter *adap)
+{
+ return mutex_lock_interruptible(&adap_to_priv(adap)->scl->lock);
+}
+
+static void i2c_gpio_post_xfer(struct i2c_adapter *adap)
+{
+ mutex_unlock(&adap_to_priv(adap)->scl->lock);
}
#ifdef CONFIG_I2C_GPIO_FAULT_INJECTOR
@@ -308,13 +337,14 @@ static struct gpio_desc *i2c_gpio_get_desc(struct device *dev,
struct gpio_desc *retdesc;
int ret;
- retdesc = devm_gpiod_get(dev, con_id, gflags);
+ /* Don't use resource-managed functions because of shared SCL */
+ retdesc = gpiod_get(dev, con_id, gflags);
if (!IS_ERR(retdesc)) {
dev_dbg(dev, "got GPIO from name %s\n", con_id);
return retdesc;
}
- retdesc = devm_gpiod_get_index(dev, NULL, index, gflags);
+ retdesc = gpiod_get_index(dev, NULL, index, gflags);
if (!IS_ERR(retdesc)) {
dev_dbg(dev, "got GPIO from index %u\n", index);
return retdesc;
@@ -336,6 +366,117 @@ static struct gpio_desc *i2c_gpio_get_desc(struct device *dev,
return retdesc;
}
+static struct i2c_gpio_scl_data *i2c_gpio_create_scl(struct fwnode_handle *fwnode)
+{
+ struct fwnode_reference_args args;
+ struct i2c_gpio_scl_data *scl;
+ int ret;
+
+ ret = fwnode_property_get_reference_args(fwnode, "scl-gpios",
+ "#gpio-cells", 0, 0, &args);
+ if (ret)
+ /* try the ancient way */
+ ret = fwnode_property_get_reference_args(fwnode, "gpios",
+ "#gpio-cells", 0, 1, &args);
+ if (ret)
+ return ERR_PTR(ret);
+
+ if (args.nargs < 2) {
+ fwnode_handle_put(args.fwnode);
+ return ERR_PTR(-EINVAL);
+ }
+
+ scl = kzalloc(sizeof(*scl), GFP_KERNEL);
+ if (!scl) {
+ fwnode_handle_put(args.fwnode);
+ return ERR_PTR(-ENOMEM);
+ }
+
+ /* The unique identification from the SCL GPIO reference in the device tree */
+ scl->fw_node = args.fwnode;
+ scl->fw_pin = args.args[0];
+ scl->fw_flags = args.args[1];
+
+ mutex_init(&scl->lock);
+ refcount_set(&scl->ref, 1);
+
+ return scl;
+}
+
+static void i2c_gpio_free_scl(struct i2c_gpio_scl_data *scl)
+{
+ fwnode_handle_put(scl->fw_node);
+ kfree(scl);
+}
+
+/*
+ * Look up an existing or create a new shared SCL structure described by the device's fwnode.
+ * If it exists, reuse it. Otherwise a new entry is allocated and the GPIO is requested.
+ *
+ * Memory allocation and gpiod_get() might sleep and must not run under a lock. To work around
+ * this, always create and add the entry to the list before requesting the GPIO. So concurrent
+ * probes for the same SCL pin see the entry and do not race into a second gpiod_get() for the
+ * same pin. The entry is marked valid only after the GPIO is successfully acquired. Until then,
+ * other consumers get -EPROBE_DEFER.
+ */
+static struct i2c_gpio_scl_data *i2c_gpio_lookup_scl(struct device *dev, enum gpiod_flags gflags)
+{
+ struct i2c_gpio_scl_data *scl, *new_scl;
+ struct gpio_desc *gpio;
+
+ new_scl = i2c_gpio_create_scl(dev_fwnode(dev));
+ if (IS_ERR(new_scl))
+ return new_scl;
+
+ scoped_guard(mutex, &i2c_gpio_scl_list_lock) {
+ list_for_each_entry(scl, &i2c_gpio_scl_list, list) {
+ if (scl->fw_node == new_scl->fw_node &&
+ scl->fw_pin == new_scl->fw_pin &&
+ scl->fw_flags == new_scl->fw_flags) {
+ i2c_gpio_free_scl(new_scl);
+ if (!scl->valid)
+ return ERR_PTR(-EPROBE_DEFER);
+
+ refcount_inc(&scl->ref);
+ dev_info(dev, "reusing shared SCL (%pfwP, pin %u)\n",
+ scl->fw_node, scl->fw_pin);
+
+ return scl;
+ }
+ }
+ list_add(&new_scl->list, &i2c_gpio_scl_list);
+ }
+
+ gpio = i2c_gpio_get_desc(dev, "scl", 1, gflags);
+ if (IS_ERR(gpio)) {
+ scoped_guard(mutex, &i2c_gpio_scl_list_lock)
+ list_del(&new_scl->list);
+ i2c_gpio_free_scl(new_scl);
+
+ return ERR_CAST(gpio);
+ }
+
+ new_scl->gpio = gpio;
+ scoped_guard(mutex, &i2c_gpio_scl_list_lock)
+ new_scl->valid = true;
+
+ dev_info(dev, "registered shared SCL (%pfwP, pin %u)\n",
+ new_scl->fw_node, new_scl->fw_pin);
+
+ return new_scl;
+}
+
+static void i2c_gpio_cleanup_scl(struct i2c_gpio_scl_data *scl)
+{
+ if (!refcount_dec_and_mutex_lock(&scl->ref, &i2c_gpio_scl_list_lock))
+ return;
+
+ list_del(&scl->list);
+ mutex_unlock(&i2c_gpio_scl_list_lock);
+ gpiod_put(scl->gpio);
+ i2c_gpio_free_scl(scl);
+}
+
static int i2c_gpio_probe(struct platform_device *pdev)
{
struct i2c_gpio_private_data *priv;
@@ -386,15 +527,17 @@ static int i2c_gpio_probe(struct platform_device *pdev)
gflags = GPIOD_OUT_HIGH;
else
gflags = GPIOD_OUT_HIGH_OPEN_DRAIN;
- priv->scl = i2c_gpio_get_desc(dev, "scl", 1, gflags);
+ priv->scl = i2c_gpio_lookup_scl(dev, gflags);
if (IS_ERR(priv->scl))
return PTR_ERR(priv->scl);
- if (gpiod_cansleep(priv->sda) || gpiod_cansleep(priv->scl))
+ if (gpiod_cansleep(priv->sda) || gpiod_cansleep(priv->scl->gpio))
dev_warn(dev, "Slow GPIO pins might wreak havoc into I2C/SMBus bus timing");
else
bit_data->can_do_atomic = true;
+ bit_data->pre_xfer = i2c_gpio_pre_xfer;
+ bit_data->post_xfer = i2c_gpio_post_xfer;
bit_data->setsda = i2c_gpio_setsda_val;
bit_data->setscl = i2c_gpio_setscl_val;
@@ -441,7 +584,7 @@ static int i2c_gpio_probe(struct platform_device *pdev)
* from the descriptor, then provide that instead.
*/
dev_info(dev, "using lines %u (SDA) and %u (SCL%s)\n",
- desc_to_gpio(priv->sda), desc_to_gpio(priv->scl),
+ desc_to_gpio(priv->sda), desc_to_gpio(priv->scl->gpio),
pdata->scl_is_output_only
? ", no clock stretching" : "");
@@ -459,6 +602,8 @@ static void i2c_gpio_remove(struct platform_device *pdev)
adap = &priv->adap;
i2c_del_adapter(adap);
+ i2c_gpio_cleanup_scl(priv->scl);
+ gpiod_put(priv->sda);
}
static const struct of_device_id i2c_gpio_dt_ids[] = {
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL
2026-05-14 9:20 [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL Markus Stockhausen
@ 2026-05-16 10:11 ` kernel test robot
2026-05-16 11:58 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-05-16 10:11 UTC (permalink / raw)
To: Markus Stockhausen; +Cc: oe-kbuild-all
Hi Markus,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on linus/master v7.1-rc3 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Stockhausen/i2c-i2c-gpio-Enhance-driver-for-buses-with-shared-SCL/20260514-233812
base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link: https://lore.kernel.org/r/20260514092042.3265986-1-markus.stockhausen%40gmx.de
patch subject: [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL
config: um-randconfig-r073-20260516 (https://download.01.org/0day-ci/archive/20260516/202605161836.Pd84kaCN-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9185-gbcc58b9c
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260516/202605161836.Pd84kaCN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605161836.Pd84kaCN-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/i2c/busses/i2c-gpio.c: In function 'i2c_gpio_fi_act_on_scl_irq':
>> drivers/i2c/busses/i2c-gpio.c:197:41: error: passing argument 1 of 'gpiod_to_irq' from incompatible pointer type [-Wincompatible-pointer-types]
197 | int ret, irq = gpiod_to_irq(priv->scl);
| ~~~~^~~~~
| |
| struct i2c_gpio_scl_data *
In file included from drivers/i2c/busses/i2c-gpio.c:10:
include/linux/gpio/consumer.h:169:42: note: expected 'const struct gpio_desc *' but argument is of type 'struct i2c_gpio_scl_data *'
169 | int gpiod_to_irq(const struct gpio_desc *desc);
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
>> drivers/i2c/busses/i2c-gpio.c:204:41: error: passing argument 1 of 'gpiod_direction_input' from incompatible pointer type [-Wincompatible-pointer-types]
204 | ret = gpiod_direction_input(priv->scl);
| ~~~~^~~~~
| |
| struct i2c_gpio_scl_data *
include/linux/gpio/consumer.h:114:45: note: expected 'struct gpio_desc *' but argument is of type 'struct i2c_gpio_scl_data *'
114 | int gpiod_direction_input(struct gpio_desc *desc);
| ~~~~~~~~~~~~~~~~~~^~~~
>> drivers/i2c/busses/i2c-gpio.c:219:42: error: passing argument 1 of 'gpiod_direction_output' from incompatible pointer type [-Wincompatible-pointer-types]
219 | ret = gpiod_direction_output(priv->scl, 1) ?: ret;
| ~~~~^~~~~
| |
| struct i2c_gpio_scl_data *
include/linux/gpio/consumer.h:115:46: note: expected 'struct gpio_desc *' but argument is of type 'struct i2c_gpio_scl_data *'
115 | int gpiod_direction_output(struct gpio_desc *desc, int value);
| ~~~~~~~~~~~~~~~~~~^~~~
vim +/gpiod_to_irq +197 drivers/i2c/busses/i2c-gpio.c
bbe899700a44af Wolfram Sang 2018-06-29 193
63e57b6f191db9 Wolfram Sang 2019-02-19 194 static int i2c_gpio_fi_act_on_scl_irq(struct i2c_gpio_private_data *priv,
63e57b6f191db9 Wolfram Sang 2019-02-19 195 irqreturn_t handler(int, void*))
63e57b6f191db9 Wolfram Sang 2019-02-19 196 {
63e57b6f191db9 Wolfram Sang 2019-02-19 @197 int ret, irq = gpiod_to_irq(priv->scl);
63e57b6f191db9 Wolfram Sang 2019-02-19 198
63e57b6f191db9 Wolfram Sang 2019-02-19 199 if (irq < 0)
63e57b6f191db9 Wolfram Sang 2019-02-19 200 return irq;
63e57b6f191db9 Wolfram Sang 2019-02-19 201
63e57b6f191db9 Wolfram Sang 2019-02-19 202 i2c_lock_bus(&priv->adap, I2C_LOCK_ROOT_ADAPTER);
63e57b6f191db9 Wolfram Sang 2019-02-19 203
63e57b6f191db9 Wolfram Sang 2019-02-19 @204 ret = gpiod_direction_input(priv->scl);
63e57b6f191db9 Wolfram Sang 2019-02-19 205 if (ret)
63e57b6f191db9 Wolfram Sang 2019-02-19 206 goto unlock;
63e57b6f191db9 Wolfram Sang 2019-02-19 207
63e57b6f191db9 Wolfram Sang 2019-02-19 208 reinit_completion(&priv->scl_irq_completion);
63e57b6f191db9 Wolfram Sang 2019-02-19 209
63e57b6f191db9 Wolfram Sang 2019-02-19 210 ret = request_irq(irq, handler, IRQF_TRIGGER_FALLING,
63e57b6f191db9 Wolfram Sang 2019-02-19 211 "i2c_gpio_fault_injector_scl_irq", priv);
63e57b6f191db9 Wolfram Sang 2019-02-19 212 if (ret)
63e57b6f191db9 Wolfram Sang 2019-02-19 213 goto output;
63e57b6f191db9 Wolfram Sang 2019-02-19 214
63e57b6f191db9 Wolfram Sang 2019-02-19 215 wait_for_completion_interruptible(&priv->scl_irq_completion);
63e57b6f191db9 Wolfram Sang 2019-02-19 216
63e57b6f191db9 Wolfram Sang 2019-02-19 217 free_irq(irq, priv);
63e57b6f191db9 Wolfram Sang 2019-02-19 218 output:
63e57b6f191db9 Wolfram Sang 2019-02-19 @219 ret = gpiod_direction_output(priv->scl, 1) ?: ret;
63e57b6f191db9 Wolfram Sang 2019-02-19 220 unlock:
63e57b6f191db9 Wolfram Sang 2019-02-19 221 i2c_unlock_bus(&priv->adap, I2C_LOCK_ROOT_ADAPTER);
63e57b6f191db9 Wolfram Sang 2019-02-19 222
63e57b6f191db9 Wolfram Sang 2019-02-19 223 return ret;
63e57b6f191db9 Wolfram Sang 2019-02-19 224 }
63e57b6f191db9 Wolfram Sang 2019-02-19 225
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL
2026-05-14 9:20 [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL Markus Stockhausen
2026-05-16 10:11 ` kernel test robot
@ 2026-05-16 11:58 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-05-16 11:58 UTC (permalink / raw)
To: Markus Stockhausen; +Cc: llvm, oe-kbuild-all
Hi Markus,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on linus/master v7.1-rc3 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Stockhausen/i2c-i2c-gpio-Enhance-driver-for-buses-with-shared-SCL/20260514-233812
base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link: https://lore.kernel.org/r/20260514092042.3265986-1-markus.stockhausen%40gmx.de
patch subject: [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL
config: arm64-randconfig-004-20260516 (https://download.01.org/0day-ci/archive/20260516/202605161950.P3hdEfkq-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260516/202605161950.P3hdEfkq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605161950.P3hdEfkq-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-gpio.c:197:30: error: incompatible pointer types passing 'struct i2c_gpio_scl_data *' to parameter of type 'const struct gpio_desc *' [-Wincompatible-pointer-types]
197 | int ret, irq = gpiod_to_irq(priv->scl);
| ^~~~~~~~~
include/linux/gpio/consumer.h:169:42: note: passing argument to parameter 'desc' here
169 | int gpiod_to_irq(const struct gpio_desc *desc);
| ^
>> drivers/i2c/busses/i2c-gpio.c:204:30: error: incompatible pointer types passing 'struct i2c_gpio_scl_data *' to parameter of type 'struct gpio_desc *' [-Wincompatible-pointer-types]
204 | ret = gpiod_direction_input(priv->scl);
| ^~~~~~~~~
include/linux/gpio/consumer.h:114:45: note: passing argument to parameter 'desc' here
114 | int gpiod_direction_input(struct gpio_desc *desc);
| ^
drivers/i2c/busses/i2c-gpio.c:219:31: error: incompatible pointer types passing 'struct i2c_gpio_scl_data *' to parameter of type 'struct gpio_desc *' [-Wincompatible-pointer-types]
219 | ret = gpiod_direction_output(priv->scl, 1) ?: ret;
| ^~~~~~~~~
include/linux/gpio/consumer.h:115:46: note: passing argument to parameter 'desc' here
115 | int gpiod_direction_output(struct gpio_desc *desc, int value);
| ^
3 errors generated.
vim +197 drivers/i2c/busses/i2c-gpio.c
bbe899700a44af Wolfram Sang 2018-06-29 193
63e57b6f191db9 Wolfram Sang 2019-02-19 194 static int i2c_gpio_fi_act_on_scl_irq(struct i2c_gpio_private_data *priv,
63e57b6f191db9 Wolfram Sang 2019-02-19 195 irqreturn_t handler(int, void*))
63e57b6f191db9 Wolfram Sang 2019-02-19 196 {
63e57b6f191db9 Wolfram Sang 2019-02-19 @197 int ret, irq = gpiod_to_irq(priv->scl);
63e57b6f191db9 Wolfram Sang 2019-02-19 198
63e57b6f191db9 Wolfram Sang 2019-02-19 199 if (irq < 0)
63e57b6f191db9 Wolfram Sang 2019-02-19 200 return irq;
63e57b6f191db9 Wolfram Sang 2019-02-19 201
63e57b6f191db9 Wolfram Sang 2019-02-19 202 i2c_lock_bus(&priv->adap, I2C_LOCK_ROOT_ADAPTER);
63e57b6f191db9 Wolfram Sang 2019-02-19 203
63e57b6f191db9 Wolfram Sang 2019-02-19 @204 ret = gpiod_direction_input(priv->scl);
63e57b6f191db9 Wolfram Sang 2019-02-19 205 if (ret)
63e57b6f191db9 Wolfram Sang 2019-02-19 206 goto unlock;
63e57b6f191db9 Wolfram Sang 2019-02-19 207
63e57b6f191db9 Wolfram Sang 2019-02-19 208 reinit_completion(&priv->scl_irq_completion);
63e57b6f191db9 Wolfram Sang 2019-02-19 209
63e57b6f191db9 Wolfram Sang 2019-02-19 210 ret = request_irq(irq, handler, IRQF_TRIGGER_FALLING,
63e57b6f191db9 Wolfram Sang 2019-02-19 211 "i2c_gpio_fault_injector_scl_irq", priv);
63e57b6f191db9 Wolfram Sang 2019-02-19 212 if (ret)
63e57b6f191db9 Wolfram Sang 2019-02-19 213 goto output;
63e57b6f191db9 Wolfram Sang 2019-02-19 214
63e57b6f191db9 Wolfram Sang 2019-02-19 215 wait_for_completion_interruptible(&priv->scl_irq_completion);
63e57b6f191db9 Wolfram Sang 2019-02-19 216
63e57b6f191db9 Wolfram Sang 2019-02-19 217 free_irq(irq, priv);
63e57b6f191db9 Wolfram Sang 2019-02-19 218 output:
63e57b6f191db9 Wolfram Sang 2019-02-19 219 ret = gpiod_direction_output(priv->scl, 1) ?: ret;
63e57b6f191db9 Wolfram Sang 2019-02-19 220 unlock:
63e57b6f191db9 Wolfram Sang 2019-02-19 221 i2c_unlock_bus(&priv->adap, I2C_LOCK_ROOT_ADAPTER);
63e57b6f191db9 Wolfram Sang 2019-02-19 222
63e57b6f191db9 Wolfram Sang 2019-02-19 223 return ret;
63e57b6f191db9 Wolfram Sang 2019-02-19 224 }
63e57b6f191db9 Wolfram Sang 2019-02-19 225
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-16 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-14 9:20 [RFC PATCH] i2c: i2c-gpio Enhance driver for buses with shared SCL Markus Stockhausen
2026-05-16 10:11 ` kernel test robot
2026-05-16 11:58 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.