From: Jonathan Cameron <jic23@kernel.org>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org,
kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz,
kyungmin.park@samsung.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 00/12] iio: ssp_sensors: driver fixes, refactor and cleanup
Date: Sun, 17 May 2026 13:50:41 +0100 [thread overview]
Message-ID: <20260517135041.01b43cca@jic23-huawei> (raw)
In-Reply-To: <20260515174017.3962168-1-sanjayembedded@gmail.com>
On Fri, 15 May 2026 23:10:05 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:
> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>
> Hi all,
>
> This patch series improves resource cleanup and error handling in the
> SSP IIO SPI driver by adopting the recently introduced cleanup
> helpers.
>
> The changes focus on making probe/remove paths more robust and easier
> to reason about by reducing manual unwind logic and ensuring that locks
> and dynamically allocated resources are released consistently across
> all exit paths.
Hi Sanjay,
Whilst I would encourage you to look at what sashiko came up with, IIRC
a lot of what it found is unrelated to the work in this series.
https://sashiko.dev/#/patchset/20260515174017.3962168-1-sanjayembedded%40gmail.com
My main concern here is that some of the changes are what I'd consider
non trivial so I think this needs some testing. Are you doing that
or is this just compile tested? Given we have a lot of new contributors
recently I'm not sure who is solving their own problems and who is looking
to help out with modernisation of old code and doesn't have hardware.
If you can't test, can any of the samsung folk help?
I have no idea if this device is present in modern chips or is just
there for legacy.
Jonathan
prev parent reply other threads:[~2026-05-17 12:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 17:40 [PATCH v8 00/12] iio: ssp_sensors: driver fixes, refactor and cleanup Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 01/12] iio: ssp_sensors: cancel delayed work_refresh on remove Sanjay Chitroda
2026-05-17 10:31 ` Andy Shevchenko
2026-05-17 12:34 ` Jonathan Cameron
2026-05-15 17:40 ` [PATCH v8 02/12] iio: ssp_sensors: factor out pending list add/remove helpers Sanjay Chitroda
2026-05-17 10:36 ` Andy Shevchenko
2026-05-15 17:40 ` [PATCH v8 03/12] iio: ssp_sensors: refactor transfer logic into helper Sanjay Chitroda
2026-05-17 12:40 ` Jonathan Cameron
2026-05-15 17:40 ` [PATCH v8 04/12] iio: ssp_sensors: factor out MCU enable/disable helpers Sanjay Chitroda
2026-05-17 10:39 ` Andy Shevchenko
2026-05-15 17:40 ` [PATCH v8 05/12] iio: ssp_sensors: use local struct device Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 06/12] iio: ssp_sensors: fix variable type and declaration order in probe() Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 07/12] iio: ssp_sensors: Drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 08/12] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 09/12] iio: ssp_sensors: use guard() to release mutexes Sanjay Chitroda
2026-05-17 10:42 ` Andy Shevchenko
2026-05-15 17:40 ` [PATCH v8 10/12] iio: ssp_sensors: Use dev_err_probe() Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 11/12] iio: ssp_sensors: return errors directly from ssp_irq_msg() Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 12/12] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
2026-05-17 12:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517135041.01b43cca@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=kees@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
--cc=sanjayembeddedse@gmail.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.