From: sashiko-bot@kernel.org
To: "Paul Kocialkowski" <paulk@sys-base.io>
Cc: linux-sunxi@lists.linux.dev, conor+dt@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 2/9] dt-bindings: media: sun6i-a31-isp: Add optional interconnect properties
Date: Mon, 18 May 2026 15:50:05 +0000 [thread overview]
Message-ID: <20260518155006.12589C2BCB7@smtp.kernel.org> (raw)
In-Reply-To: <20260518153339.619947-3-paulk@sys-base.io>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message body incorrectly refers to the 'sun6i-a31-csi' device instead of the 'sun6i-a31-isp' device.
--
commit 816ee95ed6c916a2cdd9b96a5a6e283ad0e7d42e
Author: Paul Kocialkowski <paulk@sys-base.io>
dt-bindings: media: sun6i-a31-isp: Add optional interconnect properties
This commit updates the allwinner,sun6i-a31-isp device tree binding by adding
optional interconnect and interconnect-names properties.
> An interconnect can be attached to the sun6i-a31-csi device, which is
> useful to attach the dma memory offset. Add related properties.
This isn't a bug, but should the commit message body refer to the
sun6i-a31-isp device instead of the sun6i-a31-csi device?
The patch modifies the allwinner,sun6i-a31-isp.yaml binding and the commit
title correctly indicates sun6i-a31-isp.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260518153339.619947-1-paulk@sys-base.io?part=2
next prev parent reply other threads:[~2026-05-18 15:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 15:33 [PATCH v9 0/9] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / Platform Support Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 1/9] dt-bindings: media: sun6i-a31-csi: Add optional interconnect properties Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 2/9] dt-bindings: media: sun6i-a31-isp: " Paul Kocialkowski
2026-05-18 15:50 ` sashiko-bot [this message]
2026-05-18 15:59 ` Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 3/9] clk: sunxi-ng: v3s: Export MBUS and DRAM clocks to the public header Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 4/9] ARM: dts: sun8i: v3s: Add mbus node to represent the interconnect Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 5/9] ARM: dts: sun8i: v3s: Add nodes for MIPI CSI-2 support Paul Kocialkowski
2026-05-18 16:11 ` sashiko-bot
2026-05-24 17:49 ` Chen-Yu Tsai
2026-05-26 14:13 ` Paul Kocialkowski
2026-06-13 14:11 ` Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 6/9] ARM: dts: sun8i: v3s: Add support for the ISP Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 7/9] ARM: dts: sun8i: a83t: Add MIPI CSI-2 controller node Paul Kocialkowski
2026-05-18 15:33 ` [PATCH v9 8/9] ARM: dts: sun8i-a83t: Add BananaPi M3 OV5640 camera overlay Paul Kocialkowski
2026-05-24 20:24 ` Chen-Yu Tsai
2026-05-18 15:33 ` [PATCH v9 9/9] ARM: dts: sun8i-a83t: Add BananaPi M3 OV8865 " Paul Kocialkowski
2026-05-18 17:10 ` sashiko-bot
2026-05-24 19:36 ` (subset) [PATCH v9 0/9] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / Platform Support Chen-Yu Tsai
2026-05-24 20:26 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518155006.12589C2BCB7@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=paulk@sys-base.io \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.