From: Nathan Chancellor <nathan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: torvalds@linux-foundation.org,
Benjamin Tissoires <bentiss@kernel.org>,
Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Kosina <jkosina@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure in final build
Date: Mon, 18 May 2026 12:24:08 -0700 [thread overview]
Message-ID: <20260518192408.GA2744985@ax162> (raw)
In-Reply-To: <ags8osqoMATFBslZ@sirena.org.uk>
On Mon, May 18, 2026 at 05:21:54PM +0100, Mark Brown wrote:
> Hi all,
>
> During the final build today's linux-next build (i386 defconfig) failed
> like this:
>
> In file included from /tmp/next/build/include/linux/device.h:15,
> from /tmp/next/build/include/linux/input.h:19,
> from /tmp/next/build/drivers/hid/hid-core.c:25:
> /tmp/next/build/drivers/hid/hid-core.c: In function 'hid_report_raw_event':
> /tmp/next/build/drivers/hid/hid-core.c:2053:43: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 2053 | hid_warn_ratelimited(hid, "Event data for report %d is incorrect (%d vs %ld)\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
> 110 | _p_func(dev, fmt, ##__VA_ARGS__); \
> | ^~~
> /tmp/next/build/include/linux/dev_printk.h:156:61: note: in expansion of macro 'dev_fmt'
> 156 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~
> /tmp/next/build/include/linux/dev_printk.h:215:17: note: in expansion of macro 'dev_warn'
> 215 | dev_level(dev, fmt, ##__VA_ARGS__); \
> | ^~~~~~~~~
> /tmp/next/build/include/linux/dev_printk.h:227:9: note: in expansion of macro 'dev_level_ratelimited'
> 227 | dev_level_ratelimited(dev_warn, dev, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/include/linux/hid.h:1342:9: note: in expansion of macro 'dev_warn_ratelimited'
> 1342 | dev_warn_ratelimited(&(hid)->dev, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/hid/hid-core.c:2053:17: note: in expansion of macro 'hid_warn_ratelimited'
> 2053 | hid_warn_ratelimited(hid, "Event data for report %d is incorrect (%d vs %ld)\n",
> | ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/hid/hid-core.c:2053:91: note: format string is defined here
> 2053 | hid_warn_ratelimited(hid, "Event data for report %d is incorrect (%d vs %ld)\n",
> | ~~^
> | |
> | long int
> | %d
> /tmp/next/build/drivers/hid/hid-core.c:2075:43: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 2075 | hid_warn_ratelimited(hid, "Event data for report %d was too short (%d vs %ld)\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
> 110 | _p_func(dev, fmt, ##__VA_ARGS__); \
> | ^~~
> /tmp/next/build/include/linux/dev_printk.h:156:61: note: in expansion of macro 'dev_fmt'
> 156 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~
> /tmp/next/build/include/linux/dev_printk.h:215:17: note: in expansion of macro 'dev_warn'
> 215 | dev_level(dev, fmt, ##__VA_ARGS__); \
> | ^~~~~~~~~
> /tmp/next/build/include/linux/dev_printk.h:227:9: note: in expansion of macro 'dev_level_ratelimited'
> 227 | dev_level_ratelimited(dev_warn, dev, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/include/linux/hid.h:1342:9: note: in expansion of macro 'dev_warn_ratelimited'
> 1342 | dev_warn_ratelimited(&(hid)->dev, fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/hid/hid-core.c:2075:17: note: in expansion of macro 'hid_warn_ratelimited'
> 2075 | hid_warn_ratelimited(hid, "Event data for report %d was too short (%d vs %ld)\n",
> | ^~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/hid/hid-core.c:2075:92: note: format string is defined here
> 2075 | hid_warn_ratelimited(hid, "Event data for report %d was too short (%d vs %ld)\n",
> | ~~^
> | |
> | long int
> | %d
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 2c85c61d1332e (HID: pass the buffer size to hid_report_raw_event)
>
> for which I applied a revert (note that the commit is in Linus' tree),
> also covering 206342541fc88 (HID: core: introduce
> hid_safe_input_report()).
I submitted
https://lore.kernel.org/20260517-hid-core-fix-size_t-specifier-v1-1-bfdd959ec383@kernel.org/
for this, which you could apply instead of the revert. Given how simple
it is, maybe Linus could just apply it directly to unbreak both trees?
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-05-18 19:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 16:21 linux-next: build failure in final build Mark Brown
2026-05-18 19:24 ` Nathan Chancellor [this message]
2026-05-18 20:06 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2026-04-01 14:07 Mark Brown
2026-03-27 22:01 Mark Brown
2026-03-27 22:03 ` Mark Brown
2026-03-27 22:05 ` Mark Brown
2026-03-28 2:18 ` Steven Rostedt
2026-03-26 16:04 Mark Brown
2026-03-26 17:05 ` Danilo Krummrich
2026-01-19 22:30 Mark Brown
2026-01-19 22:37 ` Miguel Ojeda
2026-01-19 23:32 ` Mark Brown
2026-01-19 22:49 ` Danilo Krummrich
2026-01-20 8:36 ` Alice Ryhl
2026-01-20 10:01 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518192408.GA2744985@ax162 \
--to=nathan@kernel.org \
--cc=bentiss@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.