All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Deborah Brouwer" <deborah.brouwer@collabora.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>,
	<boris.brezillon@collabora.com>
Subject: Re: linux-next: build failure in final build
Date: Mon, 19 Jan 2026 23:49:10 +0100	[thread overview]
Message-ID: <DFSXL1I12WPM.BDODUQNYLEPJ@kernel.org> (raw)
In-Reply-To: <aW6wfOjd17D5tUC5@sirena.org.uk>

(Cc: Boris)

On Mon Jan 19, 2026 at 11:30 PM CET, Mark Brown wrote:
> Hi all,
>
> After merging all trees, today's final linux-next build (arm64
> allyesconfig) failed like this:
>
> error[E0560]: struct `drm_panthor_gpu_info` has no field named `pad0`
>   --> /tmp/next/build/drivers/gpu/drm/tyr/gpu.rs:75:13
>    |
> 75 |             pad0: 0,
>    |             ^^^^ `drm_panthor_gpu_info` does not have this field
>    |
>    = note: available fields are: `selected_coherency`
>
> Caused by commit
>
>    8304c44631c37 (drm/tyr: use generated bindings for GpuInfo)

I had a quick look and the problem is that another tree (drm-misc-next) changed
the corresponding uAPI struct in commit ea78ec982653 ("drm/panthor: Expose the
selected coherency protocol to the UMD") without also changing the Tyr driver.

This diff in Tyr should fix the problem:

diff --git a/drivers/gpu/drm/tyr/gpu.rs b/drivers/gpu/drm/tyr/gpu.rs
index 3072562e36e5..0c85f03b8a7d 100644
--- a/drivers/gpu/drm/tyr/gpu.rs
+++ b/drivers/gpu/drm/tyr/gpu.rs
@@ -72,7 +72,7 @@ pub(crate) fn new(dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result<Self> {
             // TODO: Add texture_features_{1,2,3}.
             texture_features: [texture_features, 0, 0, 0],
             as_present,
-            pad0: 0,
+            selected_coherency: 0, // Some variant of `enum drm_panthor_gpu_coherency`.
             shader_present,
             l2_present,
             tiler_present,

  parent reply	other threads:[~2026-01-19 22:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 22:30 linux-next: build failure in final build Mark Brown
2026-01-19 22:37 ` Miguel Ojeda
2026-01-19 23:32   ` Mark Brown
2026-01-19 22:49 ` Danilo Krummrich [this message]
2026-01-20  8:36   ` Alice Ryhl
2026-01-20 10:01     ` Danilo Krummrich
  -- strict thread matches above, loose matches on Subject: below --
2026-03-26 16:04 Mark Brown
2026-03-26 17:05 ` Danilo Krummrich
2026-03-27 22:01 Mark Brown
2026-03-27 22:03 ` Mark Brown
2026-03-27 22:05 ` Mark Brown
2026-03-28  2:18 ` Steven Rostedt
2026-04-01 14:07 Mark Brown
2026-05-18 16:21 Mark Brown
2026-05-18 19:24 ` Nathan Chancellor
2026-05-18 20:06   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFSXL1I12WPM.BDODUQNYLEPJ@kernel.org \
    --to=dakr@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=boris.brezillon@collabora.com \
    --cc=broonie@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=deborah.brouwer@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.