From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 12/28] mm/damon/sysfs: implement filter dir
Date: Mon, 18 May 2026 16:41:00 -0700 [thread overview]
Message-ID: <20260518234119.97569-13-sj@kernel.org> (raw)
In-Reply-To: <20260518234119.97569-1-sj@kernel.org>
Implement a sysfs directory for letting the users to configure each data
probe filter.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/sysfs.c | 125 ++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 124 insertions(+), 1 deletion(-)
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index dad4985a826db..2dc475ea0f0f7 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -747,12 +747,46 @@ static const struct kobj_type damon_sysfs_intervals_ktype = {
.default_groups = damon_sysfs_intervals_groups,
};
+/*
+ * filter directory
+ */
+
+struct damon_sysfs_filter {
+ struct kobject kobj;
+};
+
+static struct damon_sysfs_filter *damon_sysfs_filter_alloc(void)
+{
+ return kzalloc_obj(struct damon_sysfs_filter);
+}
+
+static void damon_sysfs_filter_release(struct kobject *kobj)
+{
+ struct damon_sysfs_filter *filter = container_of(kobj,
+ struct damon_sysfs_filter, kobj);
+
+ kfree(filter);
+}
+
+static struct attribute *damon_sysfs_filter_attrs[] = {
+ NULL,
+};
+ATTRIBUTE_GROUPS(damon_sysfs_filter);
+
+static const struct kobj_type damon_sysfs_filter_ktype = {
+ .release = damon_sysfs_filter_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+ .default_groups = damon_sysfs_filter_groups,
+};
+
/*
* filters directory
*/
struct damon_sysfs_filters {
struct kobject kobj;
+ struct damon_sysfs_filter **filters_arr;
+ int nr;
};
static struct damon_sysfs_filters *damon_sysfs_filters_alloc(void)
@@ -760,12 +794,98 @@ static struct damon_sysfs_filters *damon_sysfs_filters_alloc(void)
return kzalloc_obj(struct damon_sysfs_filters);
}
+static void damon_sysfs_filters_rm_dirs(struct damon_sysfs_filters *filters)
+{
+ struct damon_sysfs_filter **filters_arr = filters->filters_arr;
+ int i;
+
+ for (i = 0; i < filters->nr; i++)
+ kobject_put(&filters_arr[i]->kobj);
+ filters->nr = 0;
+ kfree(filters_arr);
+ filters->filters_arr = NULL;
+}
+
+static int damon_sysfs_filters_add_dirs(
+ struct damon_sysfs_filters *filters, int nr_filters)
+{
+ struct damon_sysfs_filter **filters_arr, *filter;
+ int err, i;
+
+ damon_sysfs_filters_rm_dirs(filters);
+ if (!nr_filters)
+ return 0;
+
+ filters_arr = kmalloc_objs(*filters_arr, nr_filters,
+ GFP_KERNEL | __GFP_NOWARN);
+ if (!filters_arr)
+ return -ENOMEM;
+ filters->filters_arr = filters_arr;
+
+ for (i = 0; i < nr_filters; i++) {
+ filter = damon_sysfs_filter_alloc();
+ if (!filter) {
+ damon_sysfs_filters_rm_dirs(filters);
+ return -ENOMEM;
+ }
+
+ err = kobject_init_and_add(&filter->kobj,
+ &damon_sysfs_filter_ktype, &filters->kobj,
+ "%d", i);
+ if (err) {
+ kobject_put(&filter->kobj);
+ damon_sysfs_filters_rm_dirs(filters);
+ return err;
+ }
+
+ filters_arr[i] = filter;
+ filters->nr++;
+ }
+ return 0;
+}
+
+static ssize_t nr_filters_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ struct damon_sysfs_filters *filters = container_of(kobj,
+ struct damon_sysfs_filters, kobj);
+
+ return sysfs_emit(buf, "%d\n", filters->nr);
+}
+
+static ssize_t nr_filters_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ struct damon_sysfs_filters *filters;
+ int nr, err = kstrtoint(buf, 0, &nr);
+
+ if (err)
+ return err;
+ if (nr < 0)
+ return -EINVAL;
+
+ filters = container_of(kobj, struct damon_sysfs_filters, kobj);
+
+ if (!mutex_trylock(&damon_sysfs_lock))
+ return -EBUSY;
+ err = damon_sysfs_filters_add_dirs(filters, nr);
+ mutex_unlock(&damon_sysfs_lock);
+ if (err)
+ return err;
+
+ return count;
+}
+
static void damon_sysfs_filters_release(struct kobject *kobj)
{
kfree(container_of(kobj, struct damon_sysfs_filters, kobj));
}
+static struct kobj_attribute damon_sysfs_filters_nr_attr =
+ __ATTR_RW_MODE(nr_filters, 0600);
+
static struct attribute *damon_sysfs_filters_attrs[] = {
+ &damon_sysfs_filters_nr_attr.attr,
NULL,
};
ATTRIBUTE_GROUPS(damon_sysfs_filters);
@@ -811,7 +931,10 @@ static int damon_sysfs_probe_add_dirs(struct damon_sysfs_probe *attr)
static void damon_sysfs_probe_rm_dirs(struct damon_sysfs_probe *attr)
{
- kobject_put(&attr->filters->kobj);
+ if (attr->filters) {
+ damon_sysfs_filters_rm_dirs(attr->filters);
+ kobject_put(&attr->filters->kobj);
+ }
}
static void damon_sysfs_probe_release(struct kobject *kobj)
--
2.47.3
next prev parent reply other threads:[~2026-05-18 23:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 23:40 [PATCH 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-18 23:40 ` [PATCH 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-18 23:40 ` [PATCH 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-18 23:40 ` [PATCH 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-18 23:40 ` [PATCH 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-18 23:40 ` [PATCH 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-18 23:40 ` [PATCH 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-18 23:40 ` [PATCH 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-18 23:40 ` [PATCH 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-18 23:40 ` [PATCH 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-18 23:40 ` [PATCH 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-18 23:40 ` [PATCH 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-18 23:41 ` SeongJae Park [this message]
2026-05-18 23:41 ` [PATCH 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-18 23:41 ` [PATCH 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-18 23:41 ` [PATCH 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-18 23:41 ` [PATCH 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-18 23:41 ` [PATCH 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-18 23:41 ` [PATCH 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-18 23:41 ` [PATCH 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-18 23:41 ` [PATCH 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-18 23:41 ` [PATCH 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-18 23:41 ` [PATCH 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-18 23:41 ` [PATCH 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-18 23:41 ` [PATCH 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-18 23:41 ` [PATCH 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-18 23:41 ` [PATCH 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-18 23:41 ` [PATCH 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-18 23:41 ` [PATCH 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-18 23:53 ` [PATCH 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-19 0:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518234119.97569-13-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.