From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common
Date: Mon, 18 May 2026 16:41:13 -0700 [thread overview]
Message-ID: <20260518234119.97569-26-sj@kernel.org> (raw)
In-Reply-To: <20260518234119.97569-1-sj@kernel.org>
The next commit will need to find the memcg id from the user-passed path
to the memory cgroup, from sysfs.c. memcg_path_to_id() is doing that,
but defined in sysfs-schemes.c as a static function. Move the function
to sysfs-common.c and mark it as non-static, so that the next commit can
reuse the function.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/sysfs-common.c | 41 ++++++++++++++++++++++++++++++++++++++++
mm/damon/sysfs-common.h | 2 ++
mm/damon/sysfs-schemes.c | 41 ----------------------------------------
3 files changed, 43 insertions(+), 41 deletions(-)
diff --git a/mm/damon/sysfs-common.c b/mm/damon/sysfs-common.c
index 83e24a9b5a0db..bdc6ae2639e4f 100644
--- a/mm/damon/sysfs-common.c
+++ b/mm/damon/sysfs-common.c
@@ -104,3 +104,44 @@ const struct kobj_type damon_sysfs_ul_range_ktype = {
.default_groups = damon_sysfs_ul_range_groups,
};
+
+static bool damon_sysfs_memcg_path_eq(struct mem_cgroup *memcg,
+ char *memcg_path_buf, char *path)
+{
+#ifdef CONFIG_MEMCG
+ cgroup_path(memcg->css.cgroup, memcg_path_buf, PATH_MAX);
+ if (sysfs_streq(memcg_path_buf, path))
+ return true;
+#endif /* CONFIG_MEMCG */
+ return false;
+}
+
+int damon_sysfs_memcg_path_to_id(char *memcg_path, u64 *id)
+{
+ struct mem_cgroup *memcg;
+ char *path;
+ bool found = false;
+
+ if (!memcg_path)
+ return -EINVAL;
+
+ path = kmalloc_array(PATH_MAX, sizeof(*path), GFP_KERNEL);
+ if (!path)
+ return -ENOMEM;
+
+ for (memcg = mem_cgroup_iter(NULL, NULL, NULL); memcg;
+ memcg = mem_cgroup_iter(NULL, memcg, NULL)) {
+ /* skip offlined memcg */
+ if (!mem_cgroup_online(memcg))
+ continue;
+ if (damon_sysfs_memcg_path_eq(memcg, path, memcg_path)) {
+ *id = mem_cgroup_id(memcg);
+ found = true;
+ mem_cgroup_iter_break(NULL, memcg);
+ break;
+ }
+ }
+
+ kfree(path);
+ return found ? 0 : -EINVAL;
+}
diff --git a/mm/damon/sysfs-common.h b/mm/damon/sysfs-common.h
index 2099adee11d05..3079306966a91 100644
--- a/mm/damon/sysfs-common.h
+++ b/mm/damon/sysfs-common.h
@@ -59,3 +59,5 @@ int damos_sysfs_set_quota_scores(struct damon_sysfs_schemes *sysfs_schemes,
void damos_sysfs_update_effective_quotas(
struct damon_sysfs_schemes *sysfs_schemes,
struct damon_ctx *ctx);
+
+int damon_sysfs_memcg_path_to_id(char *memcg_path, u64 *id);
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index e25f4824b72fd..329cfd0bbe9f3 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -2791,47 +2791,6 @@ const struct kobj_type damon_sysfs_schemes_ktype = {
.default_groups = damon_sysfs_schemes_groups,
};
-static bool damon_sysfs_memcg_path_eq(struct mem_cgroup *memcg,
- char *memcg_path_buf, char *path)
-{
-#ifdef CONFIG_MEMCG
- cgroup_path(memcg->css.cgroup, memcg_path_buf, PATH_MAX);
- if (sysfs_streq(memcg_path_buf, path))
- return true;
-#endif /* CONFIG_MEMCG */
- return false;
-}
-
-static int damon_sysfs_memcg_path_to_id(char *memcg_path, u64 *id)
-{
- struct mem_cgroup *memcg;
- char *path;
- bool found = false;
-
- if (!memcg_path)
- return -EINVAL;
-
- path = kmalloc_array(PATH_MAX, sizeof(*path), GFP_KERNEL);
- if (!path)
- return -ENOMEM;
-
- for (memcg = mem_cgroup_iter(NULL, NULL, NULL); memcg;
- memcg = mem_cgroup_iter(NULL, memcg, NULL)) {
- /* skip offlined memcg */
- if (!mem_cgroup_online(memcg))
- continue;
- if (damon_sysfs_memcg_path_eq(memcg, path, memcg_path)) {
- *id = mem_cgroup_id(memcg);
- found = true;
- mem_cgroup_iter_break(NULL, memcg);
- break;
- }
- }
-
- kfree(path);
- return found ? 0 : -EINVAL;
-}
-
static int damon_sysfs_add_scheme_filters(struct damos *scheme,
struct damon_sysfs_scheme_filters *sysfs_filters)
{
--
2.47.3
next prev parent reply other threads:[~2026-05-18 23:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 23:40 [PATCH 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-18 23:40 ` [PATCH 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-18 23:40 ` [PATCH 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-18 23:40 ` [PATCH 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-18 23:40 ` [PATCH 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-18 23:40 ` [PATCH 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-18 23:40 ` [PATCH 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-18 23:40 ` [PATCH 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-18 23:40 ` [PATCH 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-18 23:40 ` [PATCH 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-18 23:40 ` [PATCH 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-18 23:40 ` [PATCH 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-18 23:41 ` [PATCH 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-18 23:41 ` [PATCH 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-18 23:41 ` [PATCH 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-18 23:41 ` [PATCH 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-18 23:41 ` [PATCH 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-18 23:41 ` [PATCH 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-18 23:41 ` [PATCH 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-18 23:41 ` [PATCH 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-18 23:41 ` [PATCH 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-18 23:41 ` [PATCH 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-18 23:41 ` [PATCH 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-18 23:41 ` [PATCH 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-18 23:41 ` [PATCH 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-18 23:41 ` SeongJae Park [this message]
2026-05-18 23:41 ` [PATCH 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-18 23:41 ` [PATCH 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-18 23:41 ` [PATCH 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-18 23:53 ` [PATCH 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-19 0:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518234119.97569-26-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.