From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,akpm@linux-foundation.org,ingyujang25@korea.ac.kr,akpm@linux-foundation.org
Subject: + error-inject-use-is_err-check-for-debugfs_create_file.patch added to mm-nonmm-unstable branch
Date: Mon, 18 May 2026 17:43:12 -0700 [thread overview]
Message-ID: <20260519004312.C8B2CC2BCB7@smtp.kernel.org> (raw)
The patch titled
Subject: error-inject: use IS_ERR() check for debugfs_create_file()
has been added to the -mm mm-nonmm-unstable branch. Its filename is
error-inject-use-is_err-check-for-debugfs_create_file.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/error-inject-use-is_err-check-for-debugfs_create_file.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Ingyu Jang <ingyujang25@korea.ac.kr>
Subject: error-inject: use IS_ERR() check for debugfs_create_file()
Date: Fri, 15 May 2026 04:32:14 +0900
debugfs_create_file() returns an error pointer on failure, never NULL, so
the !file check in ei_debugfs_init() never triggers and the
debugfs_remove() cleanup cannot run.
Use IS_ERR() and propagate the actual error via PTR_ERR().
Link: https://lore.kernel.org/20260514193214.2432769-1-ingyujang25@korea.ac.kr
Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/error-inject.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/lib/error-inject.c~error-inject-use-is_err-check-for-debugfs_create_file
+++ a/lib/error-inject.c
@@ -219,9 +219,9 @@ static int __init ei_debugfs_init(void)
dir = debugfs_create_dir("error_injection", NULL);
file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops);
- if (!file) {
+ if (IS_ERR(file)) {
debugfs_remove(dir);
- return -ENOMEM;
+ return PTR_ERR(file);
}
return 0;
_
Patches currently in -mm which might be from ingyujang25@korea.ac.kr are
error-inject-use-is_err-check-for-debugfs_create_file.patch
reply other threads:[~2026-05-19 0:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519004312.C8B2CC2BCB7@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=ingyujang25@korea.ac.kr \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.