+ error-inject-use-is_err-check-for-debugfs_create_file.patch added to mm-nonmm-unstable branch

+ error-inject-use-is_err-check-for-debugfs_create_file.patch added to mm-nonmm-unstable branch

[Andrew Morton]

The patch titled
     Subject: error-inject: use IS_ERR() check for debugfs_create_file()
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     error-inject-use-is_err-check-for-debugfs_create_file.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/error-inject-use-is_err-check-for-debugfs_create_file.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days

------------------------------------------------------
From: Ingyu Jang <ingyujang25@korea.ac.kr>
Subject: error-inject: use IS_ERR() check for debugfs_create_file()
Date: Fri, 15 May 2026 04:32:14 +0900

debugfs_create_file() returns an error pointer on failure, never NULL, so
the !file check in ei_debugfs_init() never triggers and the
debugfs_remove() cleanup cannot run.

Use IS_ERR() and propagate the actual error via PTR_ERR().

Link: https://lore.kernel.org/20260514193214.2432769-1-ingyujang25@korea.ac.kr
Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/error-inject.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/lib/error-inject.c~error-inject-use-is_err-check-for-debugfs_create_file
+++ a/lib/error-inject.c
@@ -219,9 +219,9 @@ static int __init ei_debugfs_init(void)
 	dir = debugfs_create_dir("error_injection", NULL);
 
 	file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops);
-	if (!file) {
+	if (IS_ERR(file)) {
 		debugfs_remove(dir);
-		return -ENOMEM;
+		return PTR_ERR(file);
 	}
 
 	return 0;
_

Patches currently in -mm which might be from ingyujang25@korea.ac.kr are

error-inject-use-is_err-check-for-debugfs_create_file.patch