All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Christian Marangi" <ansuelsmth@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, olteanv@gmail.com,
	neil.armstrong@linaro.org, vkoul@kernel.org, robh@kernel.org
Subject: Re: [PATCH v7 2/6] dt-bindings: clock: airoha: Add PHY binding for Serdes port
Date: Tue, 19 May 2026 22:18:50 +0000	[thread overview]
Message-ID: <20260519221850.6DCF81F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260519220813.28468-3-ansuelsmth@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#phy-cells` property is inadvertently permitted for the `econet,en751221-scu` compatible string, contradicting the commit message.
--

commit 36e079ebecab2b854b57826ce9314e34246cb7e4
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: clock: airoha: Add PHY binding for Serdes port

This commit adds a #phy-cells property for Serdes port selection. The port
selection is intended to only be supported for the Airoha AN7581 SoC.

> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml

[ ... ]

> @@ -65,6 +72,8 @@ allOf:
>          reg:
>            minItems: 2
>  
> +        '#phy-cells': false
> +

[Severity: Medium]
The commit message explicitly states that the Serdes port selection is
currently supported only for the Airoha AN7581 SoC.

Since #phy-cells is defined in the top-level properties block, it is
permitted for all compatible strings matching the schema unless explicitly
restricted. This block correctly restricts it for airoha,en7523-scu, but
should there also be a restriction for econet,en751221-scu?

Since econet,en751221-scu shares a conditional validation block with
airoha,en7581-scu further down in the file, it appears it implicitly
inherits the permission to use #phy-cells unless a new, separate if-then
block explicitly sets '#phy-cells': false for it.

Does this allow invalid configurations to pass validation?

>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519220813.28468-1-ansuelsmth@gmail.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Christian Marangi" <ansuelsmth@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, olteanv@gmail.com,
	neil.armstrong@linaro.org, vkoul@kernel.org, robh@kernel.org
Subject: Re: [PATCH v7 2/6] dt-bindings: clock: airoha: Add PHY binding for Serdes port
Date: Tue, 19 May 2026 22:18:50 +0000	[thread overview]
Message-ID: <20260519221850.6DCF81F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260519220813.28468-3-ansuelsmth@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#phy-cells` property is inadvertently permitted for the `econet,en751221-scu` compatible string, contradicting the commit message.
--

commit 36e079ebecab2b854b57826ce9314e34246cb7e4
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: clock: airoha: Add PHY binding for Serdes port

This commit adds a #phy-cells property for Serdes port selection. The port
selection is intended to only be supported for the Airoha AN7581 SoC.

> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml

[ ... ]

> @@ -65,6 +72,8 @@ allOf:
>          reg:
>            minItems: 2
>  
> +        '#phy-cells': false
> +

[Severity: Medium]
The commit message explicitly states that the Serdes port selection is
currently supported only for the Airoha AN7581 SoC.

Since #phy-cells is defined in the top-level properties block, it is
permitted for all compatible strings matching the schema unless explicitly
restricted. This block correctly restricts it for airoha,en7523-scu, but
should there also be a restriction for econet,en751221-scu?

Since econet,en751221-scu shares a conditional validation block with
airoha,en7581-scu further down in the file, it appears it implicitly
inherits the permission to use #phy-cells unless a new, separate if-then
block explicitly sets '#phy-cells': false for it.

Does this allow invalid configurations to pass validation?

>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519220813.28468-1-ansuelsmth@gmail.com?part=2

  reply	other threads:[~2026-05-19 22:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 22:08 [PATCH v7 0/6] airoha: an7581: USB support Christian Marangi
2026-05-19 22:08 ` Christian Marangi
2026-05-19 22:08 ` [PATCH v7 1/6] dt-bindings: soc: Add bindings for Airoha SCU Serdes lines Christian Marangi
2026-05-19 22:08   ` Christian Marangi
2026-05-19 22:08 ` [PATCH v7 2/6] dt-bindings: clock: airoha: Add PHY binding for Serdes port Christian Marangi
2026-05-19 22:08   ` Christian Marangi
2026-05-19 22:18   ` sashiko-bot [this message]
2026-05-19 22:18     ` sashiko-bot
2026-05-20  6:53   ` Krzysztof Kozlowski
2026-05-20  6:53     ` Krzysztof Kozlowski
2026-05-19 22:08 ` [PATCH v7 3/6] dt-bindings: phy: Add documentation for Airoha AN7581 USB PHY Christian Marangi
2026-05-19 22:08   ` Christian Marangi
2026-05-19 22:08 ` [PATCH v7 4/6] clk: en7523: Add support for selecting the Serdes port in SCU Christian Marangi
2026-05-19 22:08   ` Christian Marangi
2026-05-19 22:40   ` sashiko-bot
2026-05-19 22:40     ` sashiko-bot
2026-05-19 22:08 ` [PATCH v7 5/6] phy: move and rename Airoha PCIe PHY driver to dedicated directory Christian Marangi
2026-05-19 22:08   ` Christian Marangi
2026-05-19 22:58   ` sashiko-bot
2026-05-19 22:58     ` sashiko-bot
2026-05-20  3:57   ` Baruch Siach
2026-05-20  3:57     ` Baruch Siach
2026-05-19 22:08 ` [PATCH v7 6/6] phy: airoha: Add support for Airoha AN7581 USB PHY Christian Marangi
2026-05-19 22:08   ` Christian Marangi
2026-05-19 23:23   ` sashiko-bot
2026-05-19 23:23     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519221850.6DCF81F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.