From: Stephen Hemminger <stephen@networkplumber.org>
To: Feifei Wang <wff_light@vip.163.com>
Cc: dev@dpdk.org, Feifei Wang <wangfeifei40@huawei.com>
Subject: Re: [V1 1/1] net/hinic3: Add VXLAN TSO function
Date: Wed, 20 May 2026 08:06:49 -0700 [thread overview]
Message-ID: <20260520080649.67af0f2c@phoenix.local> (raw)
In-Reply-To: <20260520065817.931-2-wff_light@vip.163.com>
On Wed, 20 May 2026 14:58:15 +0800
Feifei Wang <wff_light@vip.163.com> wrote:
> The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function
>
> Signed-off-by: Feifei Wang <wangfeifei40@huawei.com>
> ---
You need to do more than just advertise the capability to get the driver
to actually work right.
AI explanation:
Error: VXLAN TSO is advertised unconditionally but the underlying hardware
feature is not. The patch adds RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO to the
unconditional tx_offload_capa assignment in hinic3_dev_infos_get(), but
the Tx path in drivers/net/hinic3/hinic3_tx.c:306-313 rejects every VXLAN
tunnel mbuf when the hardware does not have NIC_F_VXLAN_OFFLOAD:
next prev parent reply other threads:[~2026-05-20 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 6:58 [V1 0/1] Add VXLAN TSO function Feifei Wang
2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang
2026-05-20 15:06 ` Stephen Hemminger [this message]
2026-05-25 3:30 ` 回复: " wangfeifei (J)
2026-05-23 7:36 ` [V2 0/1] net/hinic3: Fix VXLAN TSO issue Feifei Wang
2026-05-23 7:36 ` [V2 1/1] " Feifei Wang
2026-05-26 3:31 ` [v3 0/1] " Feifei Wang
2026-05-26 3:31 ` [v3 1/1] " Feifei Wang
2026-05-26 12:18 ` [v4 0/1] " Feifei Wang
2026-05-26 12:18 ` [v4 1/1] " Feifei Wang
2026-05-26 13:15 ` Stephen Hemminger
2026-05-28 10:58 ` [v5 " Feifei Wang
2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang
2026-05-28 13:01 ` [v6 1/2] net/hinic3: Fix VXLAN TSO issue Feifei Wang
2026-05-28 13:01 ` [v6 2/2] net/hinic3: Modify SP230 VF device id Feifei Wang
2026-05-28 21:00 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520080649.67af0f2c@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wangfeifei40@huawei.com \
--cc=wff_light@vip.163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.