* [V1 0/1] Add VXLAN TSO function @ 2026-05-20 6:58 Feifei Wang 2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang 0 siblings, 1 reply; 16+ messages in thread From: Feifei Wang @ 2026-05-20 6:58 UTC (permalink / raw) To: dev V0: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function V1: Add sign-off in the commit message Feifei Wang (1): net/hinic3: Add VXLAN TSO function drivers/net/hinic3/hinic3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.47.0.windows.2 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [V1 1/1] net/hinic3: Add VXLAN TSO function 2026-05-20 6:58 [V1 0/1] Add VXLAN TSO function Feifei Wang @ 2026-05-20 6:58 ` Feifei Wang 2026-05-20 15:06 ` Stephen Hemminger ` (3 more replies) 0 siblings, 4 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-20 6:58 UTC (permalink / raw) To: dev; +Cc: Feifei Wang The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> --- drivers/net/hinic3/hinic3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c index f4eb788..fbadb1e 100644 --- a/drivers/net/hinic3/hinic3_ethdev.c +++ b/drivers/net/hinic3/hinic3_ethdev.c @@ -696,7 +696,7 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_VLAN_INSERT | RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM | RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | - RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | + RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) hinic3_dev_tnl_tso_support(info, nic_dev); -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [V1 1/1] net/hinic3: Add VXLAN TSO function 2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang @ 2026-05-20 15:06 ` Stephen Hemminger 2026-05-25 3:30 ` 回复: " wangfeifei (J) 2026-05-23 7:36 ` [V2 0/1] net/hinic3: Fix VXLAN TSO issue Feifei Wang ` (2 subsequent siblings) 3 siblings, 1 reply; 16+ messages in thread From: Stephen Hemminger @ 2026-05-20 15:06 UTC (permalink / raw) To: Feifei Wang; +Cc: dev, Feifei Wang On Wed, 20 May 2026 14:58:15 +0800 Feifei Wang <wff_light@vip.163.com> wrote: > The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function > > Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> > --- You need to do more than just advertise the capability to get the driver to actually work right. AI explanation: Error: VXLAN TSO is advertised unconditionally but the underlying hardware feature is not. The patch adds RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO to the unconditional tx_offload_capa assignment in hinic3_dev_infos_get(), but the Tx path in drivers/net/hinic3/hinic3_tx.c:306-313 rejects every VXLAN tunnel mbuf when the hardware does not have NIC_F_VXLAN_OFFLOAD: ^ permalink raw reply [flat|nested] 16+ messages in thread
* 回复: [V1 1/1] net/hinic3: Add VXLAN TSO function 2026-05-20 15:06 ` Stephen Hemminger @ 2026-05-25 3:30 ` wangfeifei (J) 0 siblings, 0 replies; 16+ messages in thread From: wangfeifei (J) @ 2026-05-25 3:30 UTC (permalink / raw) To: Stephen Hemminger, Feifei Wang Cc: dev@dpdk.org, chenyi (CY), huangbingkang, zengweiliang zengweiliang, Wangxin(kunpeng) > -----邮件原件----- > 发件人: Stephen Hemminger <stephen@networkplumber.org> > 发送时间: 2026年5月20日 23:07 > 收件人: Feifei Wang <wff_light@vip.163.com> > 抄送: dev@dpdk.org; wangfeifei (J) <wangfeifei40@huawei.com> > 主题: Re: [V1 1/1] net/hinic3: Add VXLAN TSO function > > On Wed, 20 May 2026 14:58:15 +0800 > Feifei Wang <wff_light@vip.163.com> wrote: > > > The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the > > VXLAN TSO function > > > > Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> > > --- > > You need to do more than just advertise the capability to get the driver to > actually work right. > > AI explanation: > > Error: VXLAN TSO is advertised unconditionally but the underlying hardware > feature is not. The patch adds RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO to the > unconditional tx_offload_capa assignment in hinic3_dev_infos_get(), but the Tx > path in drivers/net/hinic3/hinic3_tx.c:306-313 rejects every VXLAN tunnel mbuf > when the hardware does not have NIC_F_VXLAN_OFFLOAD: [Feifei] Thanks for your reviewing. Above comment is valuable, we ignore this. In the next version, we will change as below: if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO ^ permalink raw reply [flat|nested] 16+ messages in thread
* [V2 0/1] net/hinic3: Fix VXLAN TSO issue 2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang 2026-05-20 15:06 ` Stephen Hemminger @ 2026-05-23 7:36 ` Feifei Wang 2026-05-23 7:36 ` [V2 1/1] " Feifei Wang 2026-05-26 3:31 ` [v3 0/1] " Feifei Wang 2026-05-26 12:18 ` [v4 0/1] " Feifei Wang 3 siblings, 1 reply; 16+ messages in thread From: Feifei Wang @ 2026-05-23 7:36 UTC (permalink / raw) To: dev V1: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function V2: Modify the commit information issue and supplement the commit information Feifei Wang (1): net/hinic3: Fix VXLAN TSO issue drivers/net/hinic3/hinic3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.47.0.windows.2 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [V2 1/1] net/hinic3: Fix VXLAN TSO issue 2026-05-23 7:36 ` [V2 0/1] net/hinic3: Fix VXLAN TSO issue Feifei Wang @ 2026-05-23 7:36 ` Feifei Wang 0 siblings, 0 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-23 7:36 UTC (permalink / raw) To: dev; +Cc: Feifei Wang From: Feifei Wang <wangfeifei40@huawei.com> VXLAN TSO lacks a flag bit, causing the processing function to determine that the hardware does not support it, leading to improper handling. Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> --- drivers/net/hinic3/hinic3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c index f4eb788..fbadb1e 100644 --- a/drivers/net/hinic3/hinic3_ethdev.c +++ b/drivers/net/hinic3/hinic3_ethdev.c @@ -696,7 +696,7 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_VLAN_INSERT | RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM | RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | - RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | + RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) hinic3_dev_tnl_tso_support(info, nic_dev); -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [v3 0/1] net/hinic3: Fix VXLAN TSO issue 2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang 2026-05-20 15:06 ` Stephen Hemminger 2026-05-23 7:36 ` [V2 0/1] net/hinic3: Fix VXLAN TSO issue Feifei Wang @ 2026-05-26 3:31 ` Feifei Wang 2026-05-26 3:31 ` [v3 1/1] " Feifei Wang 2026-05-26 12:18 ` [v4 0/1] " Feifei Wang 3 siblings, 1 reply; 16+ messages in thread From: Feifei Wang @ 2026-05-26 3:31 UTC (permalink / raw) To: dev v1: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function v2: Modify the commit information issue and supplement the commit information v3: Revise review comments. First, deterine whether the hardware supports it, then add the flag bit. Feifei Wang (1): net/hinic3: Fix VXLAN TSO issue drivers/net/hinic3/hinic3_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.47.0.windows.2 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [v3 1/1] net/hinic3: Fix VXLAN TSO issue 2026-05-26 3:31 ` [v3 0/1] " Feifei Wang @ 2026-05-26 3:31 ` Feifei Wang 0 siblings, 0 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-26 3:31 UTC (permalink / raw) To: dev; +Cc: Feifei Wang From: Feifei Wang <wangfeifei40@huawei.com> VXLAN TSO lacks a flag bit, causing the processing function to determine that the hardware does not support it, leading to improper handling. Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> --- drivers/net/hinic3/hinic3_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c index f4eb788..5071b64 100644 --- a/drivers/net/hinic3/hinic3_ethdev.c +++ b/drivers/net/hinic3/hinic3_ethdev.c @@ -652,6 +652,8 @@ hinic3_dev_configure(struct rte_eth_dev *dev) static void hinic3_dev_tnl_tso_support(struct rte_eth_dev_info *info, struct hinic3_nic_dev *nic_dev) { + if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev)) + info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; if (HINIC3_SUPPORT_GENEVE_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; if (HINIC3_SUPPORT_IPXIP_OFFLOAD(nic_dev)) @@ -698,7 +700,6 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; - if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) hinic3_dev_tnl_tso_support(info, nic_dev); info->hash_key_size = HINIC3_RSS_KEY_SIZE; -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [v4 0/1] net/hinic3: Fix VXLAN TSO issue 2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang ` (2 preceding siblings ...) 2026-05-26 3:31 ` [v3 0/1] " Feifei Wang @ 2026-05-26 12:18 ` Feifei Wang 2026-05-26 12:18 ` [v4 1/1] " Feifei Wang 3 siblings, 1 reply; 16+ messages in thread From: Feifei Wang @ 2026-05-26 12:18 UTC (permalink / raw) To: dev v1: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function v2: Modify the commit information issue and supplement the commit information v3: Revise review comments. First, deterine whether the hardware supports it, then add the flag bit v4: Fix the compilation error caused by leading spaces Feifei Wang (1): net/hinic3: Fix VXLAN TSO issue drivers/net/hinic3/hinic3_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.47.0.windows.2 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [v4 1/1] net/hinic3: Fix VXLAN TSO issue 2026-05-26 12:18 ` [v4 0/1] " Feifei Wang @ 2026-05-26 12:18 ` Feifei Wang 2026-05-26 13:15 ` Stephen Hemminger ` (2 more replies) 0 siblings, 3 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-26 12:18 UTC (permalink / raw) To: dev; +Cc: Feifei Wang From: Feifei Wang <wangfeifei40@huawei.com> VXLAN TSO lacks a flag bit, causing the processing function to determine that the hardware does not support it, leading to improper handling. Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> --- drivers/net/hinic3/hinic3_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c index f4eb788..4776bc1 100644 --- a/drivers/net/hinic3/hinic3_ethdev.c +++ b/drivers/net/hinic3/hinic3_ethdev.c @@ -652,8 +652,12 @@ hinic3_dev_configure(struct rte_eth_dev *dev) static void hinic3_dev_tnl_tso_support(struct rte_eth_dev_info *info, struct hinic3_nic_dev *nic_dev) { + if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev)) + info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; + if (HINIC3_SUPPORT_GENEVE_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; + if (HINIC3_SUPPORT_IPXIP_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO; } @@ -698,7 +702,6 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; - if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) hinic3_dev_tnl_tso_support(info, nic_dev); info->hash_key_size = HINIC3_RSS_KEY_SIZE; -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [v4 1/1] net/hinic3: Fix VXLAN TSO issue 2026-05-26 12:18 ` [v4 1/1] " Feifei Wang @ 2026-05-26 13:15 ` Stephen Hemminger 2026-05-28 10:58 ` [v5 " Feifei Wang 2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang 2 siblings, 0 replies; 16+ messages in thread From: Stephen Hemminger @ 2026-05-26 13:15 UTC (permalink / raw) To: Feifei Wang; +Cc: dev, Feifei Wang On Tue, 26 May 2026 20:18:18 +0800 Feifei Wang <wff_light@vip.163.com> wrote: > From: Feifei Wang <wangfeifei40@huawei.com> > > VXLAN TSO lacks a flag bit, causing the processing function > to determine that the hardware does not support it, leading > to improper handling. > > Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> If this is a bug fix, it needs Fixes: tag and should have Cc: stable@dpdk.org > --- > drivers/net/hinic3/hinic3_ethdev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c > index f4eb788..4776bc1 100644 > --- a/drivers/net/hinic3/hinic3_ethdev.c > +++ b/drivers/net/hinic3/hinic3_ethdev.c > @@ -652,8 +652,12 @@ hinic3_dev_configure(struct rte_eth_dev *dev) > static void > hinic3_dev_tnl_tso_support(struct rte_eth_dev_info *info, struct hinic3_nic_dev *nic_dev) > { > + if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev)) > + info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; > + > if (HINIC3_SUPPORT_GENEVE_OFFLOAD(nic_dev)) > info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; > + > if (HINIC3_SUPPORT_IPXIP_OFFLOAD(nic_dev)) > info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO; > } > @@ -698,7 +702,6 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; > - if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) > hinic3_dev_tnl_tso_support(info, nic_dev); If you remove the if here, then you need to fix indentation on the line below. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [v5 1/1] net/hinic3: Fix VXLAN TSO issue 2026-05-26 12:18 ` [v4 1/1] " Feifei Wang 2026-05-26 13:15 ` Stephen Hemminger @ 2026-05-28 10:58 ` Feifei Wang 2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang 2 siblings, 0 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-28 10:58 UTC (permalink / raw) To: dev; +Cc: Feifei Wang, stable From: Feifei Wang <wangfeifei40@huawei.com> VXLAN TSO lacks a flag bit, causing the processing function to determine that the hardware does not support it, leading to improper handling. Fixes: 7608f0367d ("net/hinic3: add dev ops") Cc: stable@dpdk.org Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> --- drivers/net/hinic3/hinic3_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c index f4eb788..66c5c3a 100644 --- a/drivers/net/hinic3/hinic3_ethdev.c +++ b/drivers/net/hinic3/hinic3_ethdev.c @@ -652,8 +652,12 @@ hinic3_dev_configure(struct rte_eth_dev *dev) static void hinic3_dev_tnl_tso_support(struct rte_eth_dev_info *info, struct hinic3_nic_dev *nic_dev) { + if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev)) + info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; + if (HINIC3_SUPPORT_GENEVE_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; + if (HINIC3_SUPPORT_IPXIP_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO; } @@ -698,8 +702,8 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; - if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) - hinic3_dev_tnl_tso_support(info, nic_dev); + + hinic3_dev_tnl_tso_support(info, nic_dev); info->hash_key_size = HINIC3_RSS_KEY_SIZE; info->reta_size = HINIC3_RSS_INDIR_SIZE; -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [v6 0/2] net/hinic3: Fix the hinic3 driver issue 2026-05-26 12:18 ` [v4 1/1] " Feifei Wang 2026-05-26 13:15 ` Stephen Hemminger 2026-05-28 10:58 ` [v5 " Feifei Wang @ 2026-05-28 13:01 ` Feifei Wang 2026-05-28 13:01 ` [v6 1/2] net/hinic3: Fix VXLAN TSO issue Feifei Wang ` (2 more replies) 2 siblings, 3 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-28 13:01 UTC (permalink / raw) To: dev v1: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function v2: Modify the commit information issue and supplement the commit information v3: Revise review comments. First, deterine whether the hardware supports it, then add the flag bit v4: Fix the compilation error caused by leading spaces v5: Add fix tag v6: MOdify SP230 NIC vf device id Feifei Wang (2): net/hinic3: Fix VXLAN TSO issue net/hinic3: Modify SP230 VF device id drivers/net/hinic3/base/hinic3_csr.h | 2 +- drivers/net/hinic3/hinic3_ethdev.c | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.47.0.windows.2 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [v6 1/2] net/hinic3: Fix VXLAN TSO issue 2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang @ 2026-05-28 13:01 ` Feifei Wang 2026-05-28 13:01 ` [v6 2/2] net/hinic3: Modify SP230 VF device id Feifei Wang 2026-05-28 21:00 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Stephen Hemminger 2 siblings, 0 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-28 13:01 UTC (permalink / raw) To: dev; +Cc: Feifei Wang, stable From: Feifei Wang <wangfeifei40@huawei.com> VXLAN TSO lacks a flag bit, causing the processing function to determine that the hardware does not support it, leading to improper handling. Fixes: 7608f0367d ("net/hinic3: add dev ops") Cc: stable@dpdk.org Signed-off-by: Feifei Wang <wangfeifei40@huawei.com> --- drivers/net/hinic3/hinic3_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c index f4eb788..66c5c3a 100644 --- a/drivers/net/hinic3/hinic3_ethdev.c +++ b/drivers/net/hinic3/hinic3_ethdev.c @@ -652,8 +652,12 @@ hinic3_dev_configure(struct rte_eth_dev *dev) static void hinic3_dev_tnl_tso_support(struct rte_eth_dev_info *info, struct hinic3_nic_dev *nic_dev) { + if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev)) + info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; + if (HINIC3_SUPPORT_GENEVE_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; + if (HINIC3_SUPPORT_IPXIP_OFFLOAD(nic_dev)) info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO; } @@ -698,8 +702,8 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS; - if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) - hinic3_dev_tnl_tso_support(info, nic_dev); + + hinic3_dev_tnl_tso_support(info, nic_dev); info->hash_key_size = HINIC3_RSS_KEY_SIZE; info->reta_size = HINIC3_RSS_INDIR_SIZE; -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [v6 2/2] net/hinic3: Modify SP230 VF device id 2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang 2026-05-28 13:01 ` [v6 1/2] net/hinic3: Fix VXLAN TSO issue Feifei Wang @ 2026-05-28 13:01 ` Feifei Wang 2026-05-28 21:00 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Stephen Hemminger 2 siblings, 0 replies; 16+ messages in thread From: Feifei Wang @ 2026-05-28 13:01 UTC (permalink / raw) To: dev; +Cc: Feifei Wang, Feifei Wang From: Feifei Wang <wangfeifei40@huawei.com> Modify SP230 the VF device ID of the SP230 NIC. Signed-off-by: Feifei Wang <wangfeifei@huawei.com> --- drivers/net/hinic3/base/hinic3_csr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hinic3/base/hinic3_csr.h b/drivers/net/hinic3/base/hinic3_csr.h index eceb34e..7cae241 100644 --- a/drivers/net/hinic3/base/hinic3_csr.h +++ b/drivers/net/hinic3/base/hinic3_csr.h @@ -11,7 +11,7 @@ #define HINIC3_DEV_ID_VF_SP620 0x375F #define HINIC3_DEV_ID_SP230 0x0229 -#define HINIC3_DEV_ID_VF_SP230 0x3750 +#define HINIC3_DEV_ID_VF_SP230 0x022a #define HINIC3_DEV_ID_SP920 0x0224 -- 2.47.0.windows.2 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [v6 0/2] net/hinic3: Fix the hinic3 driver issue 2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang 2026-05-28 13:01 ` [v6 1/2] net/hinic3: Fix VXLAN TSO issue Feifei Wang 2026-05-28 13:01 ` [v6 2/2] net/hinic3: Modify SP230 VF device id Feifei Wang @ 2026-05-28 21:00 ` Stephen Hemminger 2 siblings, 0 replies; 16+ messages in thread From: Stephen Hemminger @ 2026-05-28 21:00 UTC (permalink / raw) To: Feifei Wang; +Cc: dev On Thu, 28 May 2026 21:01:18 +0800 Feifei Wang <wff_light@vip.163.com> wrote: > v1: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function > > v2: Modify the commit information issue and supplement the commit information > > v3: Revise review comments. First, deterine whether the hardware supports it, then add the flag bit > > v4: Fix the compilation error caused by leading spaces > > v5: Add fix tag > > v6: MOdify SP230 NIC vf device id > > Feifei Wang (2): > net/hinic3: Fix VXLAN TSO issue > net/hinic3: Modify SP230 VF device id > > drivers/net/hinic3/base/hinic3_csr.h | 2 +- > drivers/net/hinic3/hinic3_ethdev.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > Applied to next-net. Needed to add Fixes, and fix the Signed-off-by mail address on second patch. ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2026-05-28 21:00 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-20 6:58 [V1 0/1] Add VXLAN TSO function Feifei Wang 2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang 2026-05-20 15:06 ` Stephen Hemminger 2026-05-25 3:30 ` 回复: " wangfeifei (J) 2026-05-23 7:36 ` [V2 0/1] net/hinic3: Fix VXLAN TSO issue Feifei Wang 2026-05-23 7:36 ` [V2 1/1] " Feifei Wang 2026-05-26 3:31 ` [v3 0/1] " Feifei Wang 2026-05-26 3:31 ` [v3 1/1] " Feifei Wang 2026-05-26 12:18 ` [v4 0/1] " Feifei Wang 2026-05-26 12:18 ` [v4 1/1] " Feifei Wang 2026-05-26 13:15 ` Stephen Hemminger 2026-05-28 10:58 ` [v5 " Feifei Wang 2026-05-28 13:01 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Feifei Wang 2026-05-28 13:01 ` [v6 1/2] net/hinic3: Fix VXLAN TSO issue Feifei Wang 2026-05-28 13:01 ` [v6 2/2] net/hinic3: Modify SP230 VF device id Feifei Wang 2026-05-28 21:00 ` [v6 0/2] net/hinic3: Fix the hinic3 driver issue Stephen Hemminger
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.