From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes
Date: Thu, 21 May 2026 08:27:03 -0700 [thread overview]
Message-ID: <20260521082703.2991393f@kernel.org> (raw)
In-Reply-To: <e1c7eab4-b330-49ad-bd39-df7dbc0a9511@lunn.ch>
On Thu, 21 May 2026 14:17:08 +0200 Andrew Lunn wrote:
> The problem with these sorts of patches is that they often break
> stuff. This driver has been stable for a long time. Do we care about
> coding style issues enough that we are happy to possibly break it? Do
> we want to spend time on debugging it? Probably more time than it took
> to fix the checkpatch issues?
The way I look at it, Maciej is the maintainer and has access to HW.
If we have to keep this driver it's better to modernize it a bit.
If nothing else it shows the maintainer is willing to put in the effort.
next prev parent reply other threads:[~2026-05-21 15:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 11:18 [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes Maciej W. Rozycki
2026-05-20 11:18 ` [PATCH net 1/5] Revert "drivers: net: 3com: 3c509: Remove this driver" Maciej W. Rozycki
2026-05-20 11:18 ` [PATCH net 2/5] ethernet: 3c509: Fix AUI transceiver type selection Maciej W. Rozycki
2026-05-20 11:18 ` [PATCH net 3/5] ethernet: 3c509: Add GPL 2.0 SPDX license identifier Maciej W. Rozycki
2026-05-20 11:19 ` [PATCH net 4/5] ethernet: 3c509: Update documentation to match MAINTAINERS Maciej W. Rozycki
2026-05-20 11:19 ` [PATCH net 5/5] ethernet: 3c509: Fix most coding style issues Maciej W. Rozycki
2026-05-21 12:17 ` [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes Andrew Lunn
2026-05-21 12:45 ` Maciej W. Rozycki
2026-05-21 16:55 ` David Laight
2026-05-21 17:49 ` Maciej W. Rozycki
2026-05-21 21:55 ` David Laight
2026-05-21 15:27 ` Jakub Kicinski [this message]
2026-05-21 17:55 ` Maciej W. Rozycki
2026-05-21 15:28 ` Jakub Kicinski
2026-05-21 18:01 ` Maciej W. Rozycki
2026-05-21 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521082703.2991393f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.