From: David Laight <david.laight.linux@gmail.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes
Date: Thu, 21 May 2026 17:55:49 +0100 [thread overview]
Message-ID: <20260521175549.70c27369@pumpkin> (raw)
In-Reply-To: <alpine.DEB.2.21.2605211329000.1450@angie.orcam.me.uk>
On Thu, 21 May 2026 13:45:26 +0100 (BST)
"Maciej W. Rozycki" <macro@orcam.me.uk> wrote:
> On Thu, 21 May 2026, Andrew Lunn wrote:
...
> NB as I point out in the cover letter I made sure there's been no change
> to binary code produced, so I expect no fallout, and as we discussed with
> Jakub the removal of the driver broke `git blame' anyway, so there should
> be no cost associated with the cleanup.
Can 'we' make sure that the commit that re-instates it has the git tag of the
old version in the commit message.
That lets people go back across the remove-add.
-- David
>
> So as I say, may you both please weigh in pros and cons and let me know
> of the outcome? I'll then proceed accordingly.
>
> Maciej
>
next prev parent reply other threads:[~2026-05-21 16:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 11:18 [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes Maciej W. Rozycki
2026-05-20 11:18 ` [PATCH net 1/5] Revert "drivers: net: 3com: 3c509: Remove this driver" Maciej W. Rozycki
2026-05-20 11:18 ` [PATCH net 2/5] ethernet: 3c509: Fix AUI transceiver type selection Maciej W. Rozycki
2026-05-20 11:18 ` [PATCH net 3/5] ethernet: 3c509: Add GPL 2.0 SPDX license identifier Maciej W. Rozycki
2026-05-20 11:19 ` [PATCH net 4/5] ethernet: 3c509: Update documentation to match MAINTAINERS Maciej W. Rozycki
2026-05-20 11:19 ` [PATCH net 5/5] ethernet: 3c509: Fix most coding style issues Maciej W. Rozycki
2026-05-21 12:17 ` [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes Andrew Lunn
2026-05-21 12:45 ` Maciej W. Rozycki
2026-05-21 16:55 ` David Laight [this message]
2026-05-21 17:49 ` Maciej W. Rozycki
2026-05-21 21:55 ` David Laight
2026-05-21 15:27 ` Jakub Kicinski
2026-05-21 17:55 ` Maciej W. Rozycki
2026-05-21 15:28 ` Jakub Kicinski
2026-05-21 18:01 ` Maciej W. Rozycki
2026-05-21 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521175549.70c27369@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.