From: David Laight <david.laight.linux@gmail.com>
To: Thomas Gleixner <tglx@kernel.org>
Cc: Harshitha Ramamurthy <hramamurthy@google.com>,
netdev@vger.kernel.org, joshwash@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com,
jstultz@google.com, sboyd@kernel.org, willemb@google.com,
nktgrg@google.com, jfraker@google.com, ziweixiao@google.com,
maolson@google.com, jordanrhee@google.com, thostet@google.com,
alok.a.tiwari@oracle.com, pkaligineedi@google.com,
horms@kernel.org, dwmw2@infradead.org, jacob.e.keller@intel.com,
yyd@google.com, jefrogers@google.com,
linux-kernel@vger.kernel.org,
Naman Gulati <namangulati@google.com>
Subject: Re: [PATCH net-next v8 3/3] gve: implement PTP gettimex64
Date: Thu, 21 May 2026 11:08:04 +0100 [thread overview]
Message-ID: <20260521110804.654cf4b8@pumpkin> (raw)
In-Reply-To: <87mrxtwzz9.ffs@tglx>
On Wed, 20 May 2026 23:08:42 +0200
Thomas Gleixner <tglx@kernel.org> wrote:
> On Thu, May 14 2026 at 22:58, Harshitha Ramamurthy wrote:
...
> > + do {
> > + *pre_cycles = get_cycles();
>
> This is a completely non-sensical hack. Why do you need get_cycles()
> here, which is a horrible and ill-defined interface that others are
> trying to get rid of?
ISTR that it has always returned 0 on some architectures.
-- David
next prev parent reply other threads:[~2026-05-21 10:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 22:58 [PATCH net-next v8 0/3] gve: add support for PTP gettimex64 Harshitha Ramamurthy
2026-05-14 22:58 ` [PATCH net-next v8 1/3] gve: skip error logging for retryable AdminQ commands Harshitha Ramamurthy
2026-05-14 22:58 ` [PATCH net-next v8 2/3] gve: make nic clock reads thread safe Harshitha Ramamurthy
2026-05-14 22:58 ` [PATCH net-next v8 3/3] gve: implement PTP gettimex64 Harshitha Ramamurthy
2026-05-20 21:08 ` Thomas Gleixner
2026-05-20 22:16 ` Jakub Kicinski
2026-05-21 4:35 ` Jordan Rhee
2026-05-27 18:46 ` Jordan Rhee
2026-05-27 20:03 ` David Woodhouse
2026-05-28 16:22 ` Jordan Rhee
2026-05-28 17:33 ` David Woodhouse
2026-05-21 10:08 ` David Laight [this message]
2026-05-28 17:22 ` David Woodhouse
2026-05-21 11:43 ` David Woodhouse
2026-05-21 18:06 ` Thomas Gleixner
2026-05-21 19:59 ` David Woodhouse
2026-05-21 22:43 ` Thomas Gleixner
2026-05-22 0:12 ` David Woodhouse
2026-05-22 7:49 ` Thomas Gleixner
2026-05-22 8:56 ` David Woodhouse
2026-05-22 14:41 ` Thomas Gleixner
2026-05-22 10:34 ` David Woodhouse
2026-05-22 14:46 ` Thomas Gleixner
2026-05-20 1:30 ` [PATCH net-next v8 0/3] gve: add support for " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521110804.654cf4b8@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jefrogers@google.com \
--cc=jfraker@google.com \
--cc=jordanrhee@google.com \
--cc=joshwash@google.com \
--cc=jstultz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maolson@google.com \
--cc=namangulati@google.com \
--cc=netdev@vger.kernel.org \
--cc=nktgrg@google.com \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
--cc=tglx@kernel.org \
--cc=thostet@google.com \
--cc=willemb@google.com \
--cc=yyd@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.