From: David Laight <david.laight.linux@gmail.com>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: "anthonylnguyen" <anthony.l.nguyen@intel.com>,
"anthony.l.nguyen@intel.com" <przemyslaw.kitszel@intel.com>,
"andrewnetdev" <andrew+netdev@lunn.ch>,
"davem" <davem@davemloft.net>, "edumazet" <edumazet@google.com>,
"kuba" <kuba@kernel.org>, "pabeni" <pabeni@redhat.com>,
"intel-wired-lan" <intel-wired-lan@lists.osuosl.org>,
"netdev" <netdev@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next] net: e100: remove redundant static variable initializations
Date: Fri, 22 May 2026 09:20:42 +0100 [thread overview]
Message-ID: <20260522092042.5773213f@pumpkin> (raw)
In-Reply-To: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in>
On Fri, 22 May 2026 12:22:30 +0530
Ashwin Gundarapu <linuxuser509@zohomail.in> wrote:
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Not worth the churn for existing code.
-- David
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444);
> module_param(use_io, int, 0444);
> --
> 2.43.0
>
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <david.laight.linux@gmail.com>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: "anthonylnguyen" <anthony.l.nguyen@intel.com>,
"anthony.l.nguyen@intel.com" <przemyslaw.kitszel@intel.com>,
"andrewnetdev" <andrew+netdev@lunn.ch>,
"davem" <davem@davemloft.net>, "edumazet" <edumazet@google.com>,
"kuba" <kuba@kernel.org>, "pabeni" <pabeni@redhat.com>,
"intel-wired-lan" <intel-wired-lan@lists.osuosl.org>,
"netdev" <netdev@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: e100: remove redundant static variable initializations
Date: Fri, 22 May 2026 09:20:42 +0100 [thread overview]
Message-ID: <20260522092042.5773213f@pumpkin> (raw)
In-Reply-To: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in>
On Fri, 22 May 2026 12:22:30 +0530
Ashwin Gundarapu <linuxuser509@zohomail.in> wrote:
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Not worth the churn for existing code.
-- David
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444);
> module_param(use_io, int, 0444);
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-05-22 8:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 6:52 [PATCH net-next] net: e100: remove redundant static variable initializations Ashwin Gundarapu
2026-05-22 6:52 ` [Intel-wired-lan] " Ashwin Gundarapu via Intel-wired-lan
2026-05-22 6:58 ` Loktionov, Aleksandr
2026-05-22 6:58 ` Loktionov, Aleksandr
2026-05-22 8:20 ` David Laight [this message]
2026-05-22 8:20 ` David Laight
2026-05-22 15:55 ` Jakub Kicinski
2026-05-22 15:55 ` [Intel-wired-lan] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522092042.5773213f@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxuser509@zohomail.in \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.