Re: [PATCH v5 24/24] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Struct field initialization causes a compilation error due to mismatched types (missing Deref coercion).
--

commit 7dde6b480c3cf8bc2ec8ee3a89c129ed25216a30
Author: Danilo Krummrich <dakr@kernel.org>
Subject: samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data

This commit makes the Data struct lifetime-parameterized by storing a
reference to the parent pci::Device. It also updates the connect method
to retrieve the parent PCI device directly from the registration data.

> diff --git a/samples/rust/rust_driver_auxiliary.rs b/samples/rust/rust_driver_auxiliary.rs
> index e3e811a14110c..2c1351040e45e 100644
> --- a/samples/rust/rust_driver_auxiliary.rs
> +++ b/samples/rust/rust_driver_auxiliary.rs
[ ... ]
> @@ -81,33 +82,44 @@ fn probe<'bound>(
>          _info: &'bound Self::IdInfo,
>      ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
>          Ok(ParentData {
> -            _reg0: auxiliary::Registration::new(
[ ... ]
> +            _reg0: unsafe {
> +                auxiliary::Registration::new_with_lt(
> +                    pdev.as_ref(),
> +                    AUXILIARY_NAME,
> +                    0,
> +                    MODULE_NAME,
> +                    Data {
> +                        index: 0,
> +                        parent: pdev,

[Severity: Low]
Will this compile cleanly without an explicit dereference? 

In Rust, struct field initializations do not trigger implicit Deref coercions
in the same way that function arguments do. Since the parent field expects a
&pci::Device<Bound> but pdev is being provided directly, does this cause a
mismatched types error during the build? 

It might be necessary to explicitly dereference it here, perhaps using &**pdev
or a similar construct, to ensure the types match. This also applies to the
_reg1 initialization below.

> +                    },
> +                )?
> +            },
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525202921.124698-1-dakr@kernel.org?part=24