Re: [PATCH v5 07/24] rust: platform: implement Sync for Device<Bound>

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch manually implements `Sync` specifically for `platform::Device<device::Bound>` instead of generically implementing `Send` and `Sync` for all device contexts, leading to multiple gaps in thread-safety trait coverage.
--

commit 1e7bb03e034e1d473f033686b8475722ba9f181f
Author: Danilo Krummrich <dakr@kernel.org>

rust: platform: implement Sync for Device<Bound>

This commit implements the Sync trait for Device<Bound> by relying on
the fact that Bound is a zero-sized type-state marker. This allows drivers
to safely store &'bound platform::Device<Bound> inside their private data
while remaining Send.

> diff --git a/rust/kernel/platform.rs b/rust/kernel/platform.rs
> --- a/rust/kernel/platform.rs
> +++ b/rust/kernel/platform.rs
> @@ -565,3 +565,7 @@ unsafe impl Send for Device {}

[ ... ]

>  unsafe impl Sync for Device {}
> +
> +// SAFETY: Same as `Device<Normal>` -- the underlying `struct platform_device` is the same;
> +// `Bound` is a zero-sized type-state marker that does not affect thread safety.
> +unsafe impl Sync for Device<device::Bound> {}

[Severity: Medium]
Could this be implemented generically for all device contexts, such as
unsafe impl<Ctx: device::DeviceContext> Sync for Device<Ctx> {}?

By adding traits piecemeal, this creates a situation where Device<Bound>
is Sync but not Send. This prevents valid use cases like moving a
&mut Device<Bound> across threads.

Additionally, Device<Core> remains without Send or Sync implementations.
This restricts sharing &Device<Core> with scoped threads inside probe(),
which could otherwise be useful for concurrent initialization patterns.

Since the underlying C struct is identical and Ctx is a zero-sized
marker, a generic implementation for Send and Sync would cover all current
and future contexts while removing the need for duplicate unsafe blocks
across different bus modules.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525202921.124698-1-dakr@kernel.org?part=7