From: Christoph Hellwig <hch@lst.de>
To: David Sterba <dsterba@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: disguise single-data-RAID56 as RAID1/RAID1C3
Date: Tue, 26 May 2026 08:45:46 +0200 [thread overview]
Message-ID: <20260526064546.GA25187@lst.de> (raw)
In-Reply-To: <20260525101707.GV12792@suse.cz>
On Mon, May 25, 2026 at 12:17:07PM +0200, David Sterba wrote:
> > It absolutely is. Adding fast path workarounds for this is completely
> > stupid when it can be trivially handled on the mount side.
>
> It's a lazy hack at best and fix on absolutely wrong layer. The library
> should provide the support for the edge case. But we disagree on that.
No, the library should not provide hacks for something it never intended
to support, and which is a bad idea. It's also something the
implementation that the library was factored out from for btrfs use
never supported.
So adding the workaround to btrfs, which caused the problem is a
requirement. Doing it to only create mount time overhead instead of
burdening the I/O path is a very smart way to solve the problem,
while adding hacks to the I/O fastpath is everything but smart.
But in the end this is for the btrfs maintainers to decide.
prev parent reply other threads:[~2026-05-26 6:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 9:23 [PATCH 0/3] btrfs: disguise single-data-RAID56 as RAID1/RAID1C3 Qu Wenruo
2026-05-22 9:23 ` [PATCH 1/3] btrfs: remove btrfs_chunk_map::io_(align|width) members Qu Wenruo
2026-05-22 9:23 ` [PATCH 2/3] btrfs: remove duplicated block group type assignment Qu Wenruo
2026-05-22 9:23 ` [PATCH 3/3] btrfs: disguise single-data-RAID56 as RAID1/RAID1C3 Qu Wenruo
2026-05-23 14:23 ` David Sterba
2026-05-23 22:46 ` Qu Wenruo
2026-05-24 4:13 ` Qu Wenruo
2026-05-25 10:12 ` David Sterba
2026-05-25 10:25 ` Qu Wenruo
2026-05-25 6:00 ` Christoph Hellwig
2026-05-25 10:17 ` David Sterba
2026-05-25 10:39 ` Qu Wenruo
2026-05-26 6:46 ` Christoph Hellwig
2026-05-26 6:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526064546.GA25187@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.