All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mostafa Saleh <smostafa@google.com>
To: op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
	 kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Cc: maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com,
	 suzuki.poulose@arm.com, catalin.marinas@arm.com,
	jens.wiklander@linaro.org,  sumit.garg@kernel.org,
	sebastianene@google.com, vdonnefort@google.com,
	 sudeep.holla@kernel.org, Mostafa Saleh <smostafa@google.com>
Subject: [PATCH v6 1/6] optee: ffa: Add NULL check in optee_ffa_lend_protmem
Date: Wed, 27 May 2026 15:02:31 +0000	[thread overview]
Message-ID: <20260527150236.1978655-2-smostafa@google.com> (raw)
In-Reply-To: <20260527150236.1978655-1-smostafa@google.com>

Sashiko (locally) reports a possible null dereference under memory
pressure due to the lack of validation of the allocated pointer.

Fix that by adding the missing check.

Fixes: 2b78d79cdf96 ("optee: FF-A: dynamic protected memory allocation")
Signed-off-by: Mostafa Saleh <smostafa@google.com>
---
 drivers/tee/optee/ffa_abi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
index b4372fa268d0..633715b98625 100644
--- a/drivers/tee/optee/ffa_abi.c
+++ b/drivers/tee/optee/ffa_abi.c
@@ -698,6 +698,9 @@ static int optee_ffa_lend_protmem(struct optee *optee, struct tee_shm *protmem,
 	int rc;
 
 	mem_attr = kzalloc_objs(*mem_attr, ma_count);
+	if (!mem_attr)
+		return -ENOMEM;
+
 	for (n = 0; n < ma_count; n++) {
 		mem_attr[n].receiver = mem_attrs[n] & U16_MAX;
 		mem_attr[n].attrs = mem_attrs[n] >> 16;
-- 
2.54.0.746.g67dd491aae-goog


WARNING: multiple messages have this Message-ID (diff)
From: Mostafa Saleh via OP-TEE <op-tee@lists.trustedfirmware.org>
To: op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
	kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Cc: maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com,
	suzuki.poulose@arm.com, catalin.marinas@arm.com,
	sumit.garg@kernel.org, sebastianene@google.com,
	vdonnefort@google.com, sudeep.holla@kernel.org,
	Mostafa Saleh <smostafa@google.com>
Subject: [PATCH v6 1/6] optee: ffa: Add NULL check in optee_ffa_lend_protmem
Date: Wed, 27 May 2026 15:02:31 +0000	[thread overview]
Message-ID: <20260527150236.1978655-2-smostafa@google.com> (raw)
In-Reply-To: <20260527150236.1978655-1-smostafa@google.com>

Sashiko (locally) reports a possible null dereference under memory
pressure due to the lack of validation of the allocated pointer.

Fix that by adding the missing check.

Fixes: 2b78d79cdf96 ("optee: FF-A: dynamic protected memory allocation")
Signed-off-by: Mostafa Saleh <smostafa@google.com>
---
 drivers/tee/optee/ffa_abi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
index b4372fa268d0..633715b98625 100644
--- a/drivers/tee/optee/ffa_abi.c
+++ b/drivers/tee/optee/ffa_abi.c
@@ -698,6 +698,9 @@ static int optee_ffa_lend_protmem(struct optee *optee, struct tee_shm *protmem,
 	int rc;
 
 	mem_attr = kzalloc_objs(*mem_attr, ma_count);
+	if (!mem_attr)
+		return -ENOMEM;
+
 	for (n = 0; n < ma_count; n++) {
 		mem_attr[n].receiver = mem_attrs[n] & U16_MAX;
 		mem_attr[n].attrs = mem_attrs[n] >> 16;
-- 
2.54.0.746.g67dd491aae-goog


  reply	other threads:[~2026-05-27 15:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 15:02 [PATCH v6 0/6] arm_ffa, KVM: Fix FF-A emad offset calculations Mostafa Saleh
2026-05-27 15:02 ` Mostafa Saleh via OP-TEE
2026-05-27 15:02 ` Mostafa Saleh [this message]
2026-05-27 15:02   ` [PATCH v6 1/6] optee: ffa: Add NULL check in optee_ffa_lend_protmem Mostafa Saleh via OP-TEE
2026-05-27 18:55   ` Sumit Garg
2026-05-27 18:55     ` Sumit Garg via OP-TEE
2026-05-27 15:02 ` [PATCH v6 2/6] firmware: arm_ffa: Fix out-of-bound writes in ffa_setup_and_transmit() Mostafa Saleh
2026-05-27 15:02   ` Mostafa Saleh via OP-TEE
2026-05-27 15:02 ` [PATCH v6 3/6] firmware: arm_ffa: Fix Endpoint Memory Access Descriptor offset calculation Mostafa Saleh
2026-05-27 15:02   ` Mostafa Saleh via OP-TEE
2026-05-27 15:02 ` [PATCH v6 4/6] KVM: arm64: Fix bounds checking in do_ffa_mem_reclaim() Mostafa Saleh
2026-05-27 15:02   ` Mostafa Saleh via OP-TEE
2026-05-27 15:02 ` [PATCH v6 5/6] KVM: arm64: Validate the offset to the mem access descriptor Mostafa Saleh
2026-05-27 15:02   ` Mostafa Saleh via OP-TEE
2026-05-27 15:02 ` [PATCH v6 6/6] KVM: arm64: Ensure FFA ranges are page aligned Mostafa Saleh
2026-05-27 15:02   ` Mostafa Saleh via OP-TEE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260527150236.1978655-2-smostafa@google.com \
    --to=smostafa@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=jens.wiklander@linaro.org \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=oupton@kernel.org \
    --cc=sebastianene@google.com \
    --cc=sudeep.holla@kernel.org \
    --cc=sumit.garg@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=vdonnefort@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.