Re: [PATCHv2 1/2] dt-bindings: i3c: dw: add resets and reset-names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The commit documents `reset-names` for a single-entry reset, which violates DT binding guidelines and codifies a brittle pattern in the driver that causes silent hardware failures if the name is omitted in the DTS.
--

commit 5db0a7d3c21cf60d537f37725a5d5312d88c8c4f
Author: Dinh Nguyen <dinguyen@kernel.org>

dt-bindings: i3c: dw: add resets and reset-names

This commit updates the snps,dw-i3c-master binding to document the core
reset signal. It adds both the resets and reset-names properties to match
what the driver currently expects.

> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index e803457d3f554..7a39fe62bbbc0 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -35,6 +35,14 @@ properties:
>        - const: core
>        - const: apb
>  
> +  resets:
> +    items:
> +      - description: Core reset signal
> +
> +  reset-names:
> +    items:
> +      - const: core_rst
> +

[Severity: High]
This is a pre-existing issue, but documenting reset-names for a single-entry
reset codifies a brittle pattern in the driver that can cause silent hardware
failures.

DT binding guidelines recommend skipping *-names for single-entry lists.
Because reset-names is not marked as required, a DTS author could provide
a valid resets property without reset-names.

If this happens, the driver's call to request "core_rst" will fail to find
the name. Since the request is optional, it returns a NULL reset handle
instead of an error. The driver will silently proceed, but calls to assert the
reset will be no-ops, potentially leading to hardware lockups.

Should we drop reset-names from this binding and instead update the driver to
request the single reset by passing NULL instead of "core_rst"?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527174221.79259-1-dinguyen@kernel.org?part=1