Re: [PATCH v2 1/5] KVM: x86: Expose Zhaoxin SM2 CPUID feature

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch modifies `arch/x86/include/asm/cpufeatures.h` without syncing the changes to the tooling copy at `tools/arch/x86/include/asm/cpufeatures.h`.
--

commit 17e8fbfd326bc812ee6f132253d520b0c7201874
Author: Ewan Hai <ewandevelop@gmail.com>

KVM: x86: Expose Zhaoxin SM2 CPUID feature

This commit advertises the Zhaoxin SM2 algorithm and SM2_EN features to KVM
guests via CPUID 0xC0000001 EDX bits 0 and 1. It updates the CPU features
header and the KVM CPU caps initialization.

> diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
> index 1d506e5d6f46a..20b33413189c2 100644
> --- a/arch/x86/include/asm/cpufeatures.h
> +++ b/arch/x86/include/asm/cpufeatures.h
> @@ -136,6 +136,8 @@
>  #define X86_FEATURE_HYPERVISOR		( 4*32+31) /* "hypervisor" Running on a hypervisor */
>  
>  /* VIA/Cyrix/Centaur-defined CPU features, CPUID level 0xC0000001, word 5 */
> +#define X86_FEATURE_SM2			( 5*32+ 0) /* "sm2" SM2 algorithm */
> +#define X86_FEATURE_SM2_EN		( 5*32+ 1) /* "sm2_en" SM2 enabled */

[Severity: Low]
Since arch/x86/include/asm/cpufeatures.h is modified here, should this patch
also update the tooling copy at tools/arch/x86/include/asm/cpufeatures.h?

Without syncing the tooling header, tools/perf/check-headers.sh will emit a
warning during the perf tools build process indicating that the kernel ABI
header differs from the tooling version.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528032234.1322565-1-ewandevelop@gmail.com?part=1