[LTP] [PATCH 1/1] checkpatch: Disable more kernel specific checks

[LTP] [PATCH 1/1] checkpatch: Disable more kernel specific checks

[Petr Vorel]

Disable kernel specific checks:
* BIT_MACRO
mmapstress08.c:26: CHECK: Prefer using the BIT macro
=> reports against valid #define GRAN_NUMBER (1<<8)

* PREFER_DEFINED_ATTRIBUTE_MACRO
Kernel has various attribute macros, it does not make sense to check
without syncing the code
(https://github.com/linux-test-project/ltp/issues/1318).

Reported-by: Andrea Cervesato <andrea.cervesato@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
IMHO safe to merge, but sure it can wait after the release.

 .checkpatch.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.checkpatch.conf b/.checkpatch.conf
index 4aa6f709b6..4ca32f333e 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -10,7 +10,7 @@
 --strict
 
 # kernel specific
---ignore PREFER_KERNEL_TYPES,STRCPY,STRLCPY,STRNCPY
+--ignore PREFER_KERNEL_TYPES,STRCPY,STRLCPY,STRNCPY,BIT_MACRO,PREFER_DEFINED_ATTRIBUTE_MACRO
 
 # TODO: document reason
 --ignore CONST_STRUCT,VOLATILE,FILE_PATH_CHANGES,LONG_LINE,MACRO_ARG_REUSE,MULTIPLE_ASSIGNMENTS
-- 
2.54.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] checkpatch: Disable more kernel specific checks

[Andrea Cervesato via ltp]

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] checkpatch: Disable more kernel specific checks

[linuxtestproject.agent]

Hi Petr,

On Thu, 28 May 2026 12:27:57 +0200, Petr Vorel wrote:
> checkpatch: Disable more kernel specific checks

> -–ignore PREFER_KERNEL_TYPES,STRCPY,STRLCPY,STRNCPY
> +–ignore PREFER_KERNEL_TYPES,STRCPY,STRLCPY,STRNCPY,BIT_MACRO,PREFER_DEFINED_ATTRIBUTE_MACRO

Both BIT_MACRO and PREFER_DEFINED_ATTRIBUTE_MACRO are confirmed present in
scripts/checkpatch.pl, and the rationale for each is clearly documented
in the commit message. Good placement in the "kernel specific" ignore group.

All good. Reviewed.

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] checkpatch: Disable more kernel specific checks

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Since this is our tooling it should be safe for the release.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] checkpatch: Disable more kernel specific checks

[Petr Vorel]

Hi Cyril, Andrea,

thanks for your ack, merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp