From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Chas Williams <3chas3@gmail.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Subject: [PATCH v2 4/4] net/bonding: remove redundant function names from log
Date: Thu, 28 May 2026 16:59:16 -0700 [thread overview]
Message-ID: <20260529000157.235931-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20260529000157.235931-1-stephen@networkplumber.org>
The function name is already printed as part of RTE_BOND_LOG().
Fix grammar in log messages.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/bonding/rte_eth_bond_api.c | 4 ++--
drivers/net/bonding/rte_eth_bond_pmd.c | 23 ++++++++++-------------
2 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index 9e5df67c18..d9b6f1c417 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -485,8 +485,8 @@ __eth_bond_member_add_lock_free(uint16_t bonding_port_id, uint16_t member_port_i
ret = rte_eth_dev_info_get(member_port_id, &dev_info);
if (ret != 0) {
RTE_BOND_LOG(ERR,
- "%s: Error during getting device (port %u) info: %s",
- __func__, member_port_id, strerror(-ret));
+ "Error getting device (port %u) info: %s",
+ member_port_id, strerror(-ret));
return ret;
}
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 8a9c329fb8..6a4f997b5a 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -210,8 +210,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
int ret = rte_flow_validate(member_port, &flow_attr_8023ad,
flow_item_8023ad, actions, &error);
if (ret < 0) {
- RTE_BOND_LOG(ERR, "%s: %s (member_port=%d queue_id=%d)",
- __func__, error.message, member_port,
+ RTE_BOND_LOG(ERR, "%s (member_port=%u queue_id=%u)",
+ error.message, member_port,
internals->mode4.dedicated_queues.rx_qid);
return -1;
}
@@ -219,8 +219,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
ret = rte_eth_dev_info_get(member_port, &member_info);
if (ret != 0) {
RTE_BOND_LOG(ERR,
- "%s: Error during getting device (port %u) info: %s",
- __func__, member_port, strerror(-ret));
+ "Error getting device (port %u) info: %s",
+ member_port, strerror(-ret));
return ret;
}
@@ -228,8 +228,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
if (member_info.max_rx_queues < bond_dev->data->nb_rx_queues ||
member_info.max_tx_queues < bond_dev->data->nb_tx_queues) {
RTE_BOND_LOG(ERR,
- "%s: Member %d capabilities doesn't allow allocating additional queues",
- __func__, member_port);
+ "Member %u capabilities doesn't allow allocating additional queues",
+ member_port);
return -1;
}
@@ -249,9 +249,8 @@ bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {
ret = rte_eth_dev_info_get(bond_dev->data->port_id, &bond_info);
if (ret != 0) {
RTE_BOND_LOG(ERR,
- "%s: Error during getting device (port %u) info: %s",
- __func__, bond_dev->data->port_id,
- strerror(-ret));
+ "Error getting device (port %u) info: %s",
+ bond_dev->data->port_id, strerror(-ret));
return ret;
}
@@ -2346,10 +2345,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
ret = rte_eth_dev_info_get(member.port_id, &member_info);
if (ret != 0) {
RTE_BOND_LOG(ERR,
- "%s: Error during getting device (port %u) info: %s",
- __func__,
- member.port_id,
- strerror(-ret));
+ "Error getting device (port %u) info: %s",
+ member.port_id, strerror(-ret));
return ret;
}
--
2.53.0
next prev parent reply other threads:[~2026-05-29 0:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 16:51 [PATCH 0/3] net/bond: fix secondary process crash and related cleanup Stephen Hemminger
2026-04-17 16:51 ` [PATCH 1/3] net/bonding: restore dedicated queue state on mode set error Stephen Hemminger
2026-05-27 16:19 ` Bruce Richardson
2026-04-17 16:51 ` [PATCH 2/3] net/bonding: prevent crash on Rx/Tx from secondary process Stephen Hemminger
2026-05-27 16:24 ` Bruce Richardson
2026-04-17 16:51 ` [PATCH 3/3] net/bonding: remove redundant function names from log Stephen Hemminger
2026-05-27 16:28 ` Bruce Richardson
2026-05-08 17:59 ` [PATCH 0/3] net/bond: fix secondary process crash and related cleanup Stephen Hemminger
2026-05-28 23:59 ` [PATCH v2 0/4] net/bond: fixes and cleanup Stephen Hemminger
2026-05-28 23:59 ` [PATCH v2 1/4] net/bonding: make 8023ad enable function void Stephen Hemminger
2026-05-28 23:59 ` [PATCH v2 2/4] net/bonding: check mode before setting dedicated queues Stephen Hemminger
2026-05-28 23:59 ` [PATCH v2 3/4] net/bonding: prevent crash on Rx/Tx from secondary process Stephen Hemminger
2026-05-28 23:59 ` Stephen Hemminger [this message]
2026-06-18 16:00 ` [PATCH v2 0/4] net/bond: fixes and cleanup Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529000157.235931-5-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.