Re: [PATCH v1 4/6] power: Use named initializers for platform_device_id arrays

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The explicit `.driver_data` initialization `TYPE_MAX8998` for `max8998-battery` was silently dropped without mention in the commit message.
--

commit 02f2c38ebeef8dff34934050c70916818fb36a18
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

power: Use named initializers for platform_device_id arrays

This commit updates various power supply and reset drivers to use named
initializers for platform_device_id arrays. It also unifies spacing and
comma usage across these array definitions.

> diff --git a/drivers/power/supply/max8998_charger.c b/drivers/power/supply/max8998_charger.c
> index 418b882b163d1..b0eda2b51e7f0 100644
> --- a/drivers/power/supply/max8998_charger.c
> +++ b/drivers/power/supply/max8998_charger.c
> @@ -188,7 +188,7 @@ static int max8998_battery_probe(struct platform_device *pdev)
>  }
>  
>  static const struct platform_device_id max8998_battery_id[] = {
> -	{ "max8998-battery", TYPE_MAX8998 },
> +	{ .name = "max8998-battery" },

[Severity: Low]
Is it intentional that the TYPE_MAX8998 driver data assignment was dropped
here?

The explicit .driver_data initialization TYPE_MAX8998 for max8998-battery
was silently dropped without mention in the commit message. While this has
no functional impact as TYPE_MAX8998 evaluates to 0 and the driver data is
entirely unused in max8998_battery_probe(), it constitutes a minor code
and commit message mismatch.

Should this removal be documented in the commit message, or perhaps moved
to an earlier patch in the series that drops unused assignments of
platform_device_id driver data?

>  	{ }
>  };
>  MODULE_DEVICE_TABLE(platform, max8998_battery_id);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780048925.git.u.kleine-koenig@baylibre.com?part=4