Re: [PATCH v1 4/6] power: Use named initializers for platform_device_id arrays

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

On Fri, May 29, 2026 at 11:02:29AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The explicit `.driver_data` initialization `TYPE_MAX8998` for `max8998-battery` was silently dropped without mention in the commit message.
> --
> 
> commit 02f2c38ebeef8dff34934050c70916818fb36a18
> Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> power: Use named initializers for platform_device_id arrays
> 
> This commit updates various power supply and reset drivers to use named
> initializers for platform_device_id arrays. It also unifies spacing and
> comma usage across these array definitions.
> 
> > diff --git a/drivers/power/supply/max8998_charger.c b/drivers/power/supply/max8998_charger.c
> > index 418b882b163d1..b0eda2b51e7f0 100644
> > --- a/drivers/power/supply/max8998_charger.c
> > +++ b/drivers/power/supply/max8998_charger.c
> > @@ -188,7 +188,7 @@ static int max8998_battery_probe(struct platform_device *pdev)
> >  }
> >  
> >  static const struct platform_device_id max8998_battery_id[] = {
> > -	{ "max8998-battery", TYPE_MAX8998 },
> > +	{ .name = "max8998-battery" },
> 
> [Severity: Low]
> Is it intentional that the TYPE_MAX8998 driver data assignment was dropped
> here?

Yes, it was intentional, but that change doesn't fit to the commit log.

The driver doesn't use the value in .driver_data, so the change is fine
in principle. Given that the patch was already applied, I think it's
fine to keep it as is, but of course I'm open to respin with that detail
fixed.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]