From: sashiko-bot@kernel.org
To: "Vitor Soares" <ivitro@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v1 4/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI with adapter
Date: Fri, 29 May 2026 13:58:51 +0000 [thread overview]
Message-ID: <20260529135852.43F251F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260529120853.636015-13-ivitro@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undocumented compatible string and vendor prefix for 'riverdi'
--
commit 1ed674eebe23fa54174222cfe24295de9c767b11
Author: Vitor Soares <vitor.soares@toradex.com>
arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI with adapter
This commit adds a device tree overlay for the Toradex Capacitive Touch
Display 7" DSI used on the Aquila Development Board. It configures the DSI to
LVDS bridge, touchscreen interface, and panel timings.
Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-7inch-dsi
Link: https://developer.toradex.com/hardware/accessories/add-ons/dsi-display-adapter
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-aquila-adapter-panel-cap-touch-7inch-dsi.dtso b/arch/arm64/boot/dts/ti/k3-am69-aquila-adapter-panel-cap-touch-7inch-dsi.dtso
> new file mode 100644
> index 0000000000000..9c8ab35ef673c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am69-aquila-adapter-panel-cap-touch-7inch-dsi.dtso
[ ... ]
> +&{/} {
> + backlight_pwm3: backlight-pwm3 {
> + compatible = "pwm-backlight";
> + brightness-levels = <0 45 63 88 119 158 203 255>;
> + default-brightness-level = <4>;
> + /* Aquila PWM_3_DSI (AQUILA B46) */
> + pwms = <&main_ehrpwm5 0 6666667 0>;
> + };
> +
> + panel-lvds-bridge {
> + compatible = "riverdi,rvt70hslnwca0", "panel-lvds";
[Severity: Low]
Is the vendor prefix 'riverdi' missing from vendor-prefixes.yaml?
Should the panel variant 'riverdi,rvt70hslnwca0' also be documented in
panel-lvds.yaml?
Including undocumented compatible strings will cause dtbs_check to fail with
schema validation errors.
> + backlight = <&backlight_pwm3>;
> + data-mapping = "vesa-24";
> + height-mm = <86>;
> + width-mm = <154>;
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529120853.636015-9-ivitro@gmail.com?part=4
next prev parent reply other threads:[~2026-05-29 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 12:08 [PATCH v1 0/7] arm64: dts: ti: k3-am69-aquila: Add display and peripheral overlays Vitor Soares
2026-05-29 12:08 ` [PATCH v1 1/7] arm64: dts: ti: k3-am69-aquila: Add Toradex DSI to HDMI Adapter Vitor Soares
2026-05-29 12:08 ` [PATCH v1 2/7] arm64: dts: ti: k3-am69-aquila: Add DSI to LVDS adapter with 10.1" display Vitor Soares
2026-05-29 12:08 ` [PATCH v1 3/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 10.1" DSI with adapter Vitor Soares
2026-05-29 13:32 ` sashiko-bot
2026-05-29 12:08 ` [PATCH v1 4/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" " Vitor Soares
2026-05-29 13:58 ` sashiko-bot [this message]
2026-05-29 12:08 ` [PATCH v1 5/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 10.1" DSI Vitor Soares
2026-05-29 14:25 ` sashiko-bot
2026-05-29 12:08 ` [PATCH v1 6/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI Vitor Soares
2026-05-29 15:24 ` sashiko-bot
2026-05-29 17:18 ` Vitor Soares
2026-05-29 12:08 ` [PATCH v1 7/7] arm64: dts: ti: k3-am69-aquila: Add Toradex OV5640 CSI cameras Vitor Soares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529135852.43F251F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivitro@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.