Re: [PATCH v1 5/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 10.1" DSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The panel compatible string 'riverdi,rvt101hvlnwc00' is used for the LVDS panel without being documented in any dt-binding schema.
--

commit 16f710376251336a2f18cb25c4edfa0ffe46414a
Author: Vitor Soares <vitor.soares@toradex.com>

arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 10.1" DSI

This commit adds a device tree overlay for the Toradex Capacitive Touch
Display 10.1 inch DSI on the Aquila DSI_1 interface. It also updates the
Makefile to combine the overlay with the Aquila AM69 Clover carrier board
device tree to provide a ready-to-use DTB.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-dsi

> diff --git a/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-10inch-dsi.dtso b/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-10inch-dsi.dtso
> new file mode 100644
> index 0000000000000..3880026951f36
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-10inch-dsi.dtso
[ ... ]
> +&{/} {
> +	backlight_pwm3: backlight-pwm3 {
> +		compatible = "pwm-backlight";
> +		brightness-levels = <0 45 63 88 119 158 203 255>;
> +		default-brightness-level = <4>;
> +		/* Aquila PWM_3_DSI (AQUILA B46) */
> +		pwms = <&main_ehrpwm5 0 6666667 0>;
> +	};
> +
> +	panel-lvds-bridge {
> +		compatible = "riverdi,rvt101hvlnwc00", "panel-lvds";

[Severity: Low]
Is the riverdi,rvt101hvlnwc00 compatible string missing from the device tree
bindings documentation?

It looks like this panel is used without being documented in any dt-binding
schema, such as the panel-lvds.yaml items enum. This will likely cause make
dtbs_check to fail with a validation error since unevaluatedProperties restricts
the allowed compatible items.

> +		backlight = <&backlight_pwm3>;
> +		data-mapping = "vesa-24";
> +		height-mm = <136>;
> +		width-mm = <217>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529120853.636015-9-ivitro@gmail.com?part=5