Re: [PATCH 13/23] net: bcmgenet: use platform_device_set_of_node()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mixing `goto`-based error handling and scope-based cleanup (`__free`) in the same function.
--

commit f58d150fd8f8c2ac44d34e557009b66b7a1a1343
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

net: bcmgenet: use platform_device_set_of_node()

This commit uses the platform_device_set_of_node() helper to assign the OF
node for dynamically allocated platform devices. This is done ahead of
reworking the reference counting logic for platform devices.

> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index a4e0d5a682687..451b23a039ceb 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -490,10 +490,14 @@ static int bcmgenet_mii_register(struct bcmgenet_priv *priv)
>  	/* Retain this platform_device pointer for later cleanup */
>  	priv->mii_pdev = ppdev;
>  	ppdev->dev.parent = &pdev->dev;
> -	if (dn)
> -		ppdev->dev.of_node = bcmgenet_mii_of_find_mdio(priv);
> -	else
> +
> +	if (dn) {
> +		struct device_node *np __free(device_node) = bcmgenet_mii_of_find_mdio(priv);

[Severity: Low]
Does this mix scope-based cleanup and goto-based error handling in the same
function?

The bcmgenet_mii_register() function currently uses a goto-based cleanup path
later in the function. According to include/linux/cleanup.h, the expectation
is that usage of goto and cleanup helpers should never be mixed in the same
function.

Could the entire function be converted to use scope-based cleanups, or should
this remain as a traditional cleanup to avoid mixing the two patterns?

> +
> +		platform_device_set_of_node(ppdev, np);
> +	} else {
>  		ppd.phy_mask = ~0;
> +	}
>  
>  	ret = platform_device_add_resources(ppdev, &res, 1);
>  	if (ret)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com?part=13