Re: [LTP] gitignore: ignore ltp-agent setup files

[linuxtestproject.agent@gmail.com]

Hi Andrea,

Thank you for the patch.

> gitignore: ignore ltp-agent setup files
>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>

The commit message is missing a body. Please add a brief explanation of
what these entries are and why they need to be ignored — e.g. that they
are files and symlinks injected at runtime by the ltp-agent tool into
the LTP working directory, and must not be tracked or committed.

> +# ltp-agent setup
> +AGENTS.md
> +GEMINI.md
> +.agents
> +.claude
> +agents
> +linter
> +skills

The `linter` entry is problematic. The upstream LTP repository tracks a
`linter/` directory containing the `ltp-linter` script. In a normal LTP
checkout, adding `linter` (without a leading `/`) to `.gitignore` will
silently suppress any new, untracked files a developer adds to that
directory from appearing in `git status`. This can easily cause
work-in-progress changes to the linter to go unnoticed.

Use an anchored, directory-specific pattern to limit the match to the
ltp-agent-injected symlink at the repository root:

  /linter/

The same logic applies to `agents` and `skills`: prefer anchored
patterns (`/agents/`, `/skills/`) so they only match at the root and
cannot accidentally shadow tracked subtrees in the future.

The remaining entries (AGENTS.md, GEMINI.md, .agents, .claude) are
fine as-is since they are specific enough not to conflict with anything
currently tracked in LTP.

Overall: Needs revision ✗

---
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp