All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: LTP AI Reviewer <ltp-ai@ltp.example.com>, ltp@lists.linux.it
Subject: Re: [LTP] gitignore: ignore ltp-agent setup files
Date: Mon,  1 Jun 2026 09:39:46 +0000	[thread overview]
Message-ID: <20260601093946.4671-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260601-gitignore_ltp_agent-v3-1-b39af1578972@suse.com>

Hi Andrea,

On Mon, 01 Jun 2026 08:46:10 +0200, Andrea Cervesato wrote:
> gitignore: ignore ltp-agent setup files

Infrastructure-only patch (`.gitignore` only) — code review checklist
skipped per protocol.

COMMIT MESSAGE
--------------
The subject follows <area>: <description> format with imperative mood.

The body accurately enumerates the injected artefacts: AGENTS.md, GEMINI.md,
.agents, .claude, and the agents/, linter/, skills/ symlinks.

The rationale for root-anchoring /agents, /linter, and /skills with a
leading '/' and no trailing slash is correct:
  - Leading '/' prevents shadowing same-named subdirectories deeper in the
    tree (e.g. a hypothetical testcases/foo/agents/).
  - Omitting the trailing slash is necessary because these are symlinks; a
    trailing slash in .gitignore only matches real directories, not symlinks,
    so the entries would silently fail to suppress them without it.

/.pi/ correctly uses both a root anchor and a trailing slash (actual
directory, not a symlink).

PATCH CORRECTNESS
-----------------
All nine added entries map 1:1 to the artefacts described in the body.
The two comment headers ("# ltp-agent setup" and "# agents files") cleanly
separate the injected runtime artefacts from the scratch working files.

The unanchored entries (.agents, .claude, review-inline.txt, AGENTS.md,
GEMINI.md) lack a leading '/'. This makes them match anywhere in the tree,
not just at the root. For .agents and .claude this is a slight overshoot
compared to the anchored treatment of /agents, /linter, /skills, but the
commit body does not claim these are anchored. In practice, no test code
creates .agents or .claude subdirectories, so no false suppression is
expected. This is noted for completeness but does not require a fix.

Verdict: Reviewed ✓

Reviewed-by: LTP AI Reviewer <ltp-ai@ltp.example.com>

LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2026-06-01  9:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  6:46 [LTP] [PATCH v3] gitignore: ignore ltp-agent setup files Andrea Cervesato
2026-06-01  8:50 ` Petr Vorel
2026-06-01  9:01   ` Andrea Cervesato via ltp
2026-06-01  8:56 ` Cyril Hrubis
2026-06-01  9:39 ` linuxtestproject.agent [this message]
2026-06-01  9:57 ` Andrea Cervesato via ltp
  -- strict thread matches above, loose matches on Subject: below --
2026-06-01  6:42 [LTP] [PATCH v2] " Andrea Cervesato
2026-06-01  9:37 ` [LTP] " linuxtestproject.agent
2026-05-30  7:32 [LTP] [PATCH] " Andrea Cervesato
2026-05-30  9:22 ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601093946.4671-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp-ai@ltp.example.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.