* [merged mm-stable] mm-memory_hotplug-factor-out-altmap-freeing-checks.patch removed from -mm tree
@ 2026-06-02 22:23 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-06-02 22:23 UTC (permalink / raw)
To: mm-commits, osalvador, donettom, david, songmuchun, akpm
The quilt patch titled
Subject: mm/memory_hotplug: factor out altmap freeing checks
has been removed from the -mm tree. Its filename was
mm-memory_hotplug-factor-out-altmap-freeing-checks.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Muchun Song <songmuchun@bytedance.com>
Subject: mm/memory_hotplug: factor out altmap freeing checks
Date: Mon, 11 May 2026 16:43:07 +0800
Use a small helper to centralize altmap freeing after verifying that all
vmemmap pages were released. This keeps the check consistent between the
normal teardown path and the memory hotplug error paths.
Link: https://lore.kernel.org/20260511084307.1827127-1-songmuchun@bytedance.com
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Suggested-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Donet Tom <donettom@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memory_hotplug.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
--- a/mm/memory_hotplug.c~mm-memory_hotplug-factor-out-altmap-freeing-checks
+++ a/mm/memory_hotplug.c
@@ -1403,6 +1403,12 @@ bool mhp_supports_memmap_on_memory(void)
}
EXPORT_SYMBOL_GPL(mhp_supports_memmap_on_memory);
+static void altmap_free(struct vmem_altmap *altmap)
+{
+ WARN_ONCE(altmap->alloc, "Altmap not fully unmapped");
+ kfree(altmap);
+}
+
static void remove_memory_blocks_and_altmaps(u64 start, u64 size)
{
unsigned long memblock_size = memory_block_size_bytes();
@@ -1427,12 +1433,8 @@ static void remove_memory_blocks_and_alt
put_device(&mem->dev);
remove_memory_block_devices(cur_start, memblock_size);
-
arch_remove_memory(cur_start, memblock_size, altmap, NULL);
-
- /* Verify that all vmemmap pages have actually been freed. */
- WARN(altmap->alloc, "Altmap not fully unmapped");
- kfree(altmap);
+ altmap_free(altmap);
}
}
@@ -1463,7 +1465,7 @@ static int create_altmaps_and_memory_blo
/* call arch's memory hotadd */
ret = arch_add_memory(nid, cur_start, memblock_size, ¶ms);
if (ret < 0) {
- kfree(params.altmap);
+ altmap_free(params.altmap);
goto out;
}
@@ -1472,7 +1474,7 @@ static int create_altmaps_and_memory_blo
params.altmap, group);
if (ret) {
arch_remove_memory(cur_start, memblock_size, params.altmap, NULL);
- kfree(params.altmap);
+ altmap_free(params.altmap);
goto out;
}
}
_
Patches currently in -mm which might be from songmuchun@bytedance.com are
mm-sparse-vmemmap-provide-generic-vmemmap_set_pmd-and-vmemmap_check_pmd.patch
arm64-mm-drop-vmemmap_pmd-helpers-and-use-generic-code.patch
riscv-mm-drop-vmemmap_pmd-helpers-and-use-generic-code.patch
loongarch-mm-drop-vmemmap_check_pmd-helper-and-use-generic-code.patch
sparc-mm-drop-vmemmap_check_pmd-helper-and-use-generic-code.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-02 22:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-02 22:23 [merged mm-stable] mm-memory_hotplug-factor-out-altmap-freeing-checks.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.