All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] rust-analyzer: update generate_rust_analyzer to pass cfg to macros crate
@ 2026-06-03 14:20 Malte Wechter
  2026-06-03 14:27 ` Tamir Duberstein
  0 siblings, 1 reply; 2+ messages in thread
From: Malte Wechter @ 2026-06-03 14:20 UTC (permalink / raw)
  To: Miguel Ojeda, Boqun Feng, Gary Guo, Björn Roy Baron,
	Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
	Danilo Krummrich, Tamir Duberstein, Jesung Yang, David Gow
  Cc: rust-for-linux, linux-kernel, Malte Wechter

The configuration passed to rust-analyzer for the `macros` create is
different from the configuration used to build the crate. Update
rust-analyzer configuration for the `macros` crate to reflect the
settings used to compile the crate. Without this change, rust-analyzer
does not understand conditional compilation gated by configuration
redicates based on the `CONFIG_*`configuration values in the macros
crate.

Fixes: 36174d16f3ec ("rust: kunit: support KUnit-mapped `assert!` macros in `#[test]`s")
Signed-off-by: Malte Wechter <maltewechter@gmail.com>
---
We are currently moving the 'configfs_attrs' macro to a procedual implementation,
with this we wanted to gate the macro on CONFIG_CONFIGFS_FS, since the macros crate is
build with these configurations since 36174d16 ("rust: kunit: support KUnit-mapped `assert!` macros in `#[test]`s").
It compiles but rust-analyzer does not reflect this as adding:
 
    #[cfg(CONFIG_CONFIGFS_FS)]
    mod configfs_attrs;

will _never_ mark configfs_attrs module as included since the cfg's are not passed to
the macros crate.
---
Changes in v3:
- Add fixes tag
- Link to v2: https://lore.kernel.org/r/20260520-rust-analyzer-macro-v2-1-bcf5bdeca1a1@gmail.com

Changes in v2:
- Update commit message
- Link to v1: https://lore.kernel.org/r/20260508-rust-analyzer-macro-v1-1-9122b940d003@gmail.com
---
 scripts/generate_rust_analyzer.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
index d5f9a0ca742c..69990a96522e 100755
--- a/scripts/generate_rust_analyzer.py
+++ b/scripts/generate_rust_analyzer.py
@@ -238,6 +238,7 @@ def generate_crates(
         "macros",
         srctree / "rust" / "macros" / "lib.rs",
         [std, proc_macro, proc_macro2, quote, syn],
+        cfg=generated_cfg,
     )
 
     build_error = append_crate(

---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260506-rust-analyzer-macro-22f387f8eff4

Best regards,
-- 
Malte Wechter <maltewechter@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] rust-analyzer: update generate_rust_analyzer to pass cfg to macros crate
  2026-06-03 14:20 [PATCH v3] rust-analyzer: update generate_rust_analyzer to pass cfg to macros crate Malte Wechter
@ 2026-06-03 14:27 ` Tamir Duberstein
  0 siblings, 0 replies; 2+ messages in thread
From: Tamir Duberstein @ 2026-06-03 14:27 UTC (permalink / raw)
  To: Miguel Ojeda, Boqun Feng, Gary Guo, Björn Roy Baron,
	Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
	Danilo Krummrich, Jesung Yang, David Gow, Malte Wechter
  Cc: rust-for-linux, linux-kernel


On Wed, 03 Jun 2026 16:20:51 +0200, Malte Wechter wrote:
> rust-analyzer: update generate_rust_analyzer to pass cfg to macros crate

Applied, thanks!

[1/1] rust-analyzer: update generate_rust_analyzer to pass cfg to macros crate
      commit: 749daf28a5522af5cab92e8d3aea02c2cac2941f

Best regards,
-- 
Tamir Duberstein <tamird@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-03 14:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03 14:20 [PATCH v3] rust-analyzer: update generate_rust_analyzer to pass cfg to macros crate Malte Wechter
2026-06-03 14:27 ` Tamir Duberstein

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.