All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, jakub@cloudflare.com,
	maxime.chevallier@bootlin.com, nb@tipi-net.de, lee@kernel.org,
	linux-leds@vger.kernel.org, pavel@kernel.org, jv@jvosburgh.net,
	michael.chan@broadcom.com, jhs@mojatatu.com,
	vinicius.gomes@intel.com, idosch@nvidia.com, razor@blackwall.org,
	hare@suse.de, jhasan@marvell.com, danieller@nvidia.com,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 03/11] net: document NETDEV_CHANGENAME as ops locked
Date: Tue,  2 Jun 2026 18:28:32 -0700	[thread overview]
Message-ID: <20260603012840.2254293-4-kuba@kernel.org> (raw)
In-Reply-To: <20260603012840.2254293-1-kuba@kernel.org>

NETDEV_CHANGENAME is only emitted from netif_change_name().
netif_change_name() has two callers both of which hold netdev_lock_ops()
around the call site:
 - dev_change_name()
 - do_setlink()

Document NETDEV_CHANGENAME as always ops locked.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 Documentation/networking/netdevices.rst | 1 +
 net/core/lock_debug.c                   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
index 60492d4df2ee..8fc96975b3bd 100644
--- a/Documentation/networking/netdevices.rst
+++ b/Documentation/networking/netdevices.rst
@@ -415,6 +415,7 @@ instance lock.
 For devices with locked ops, currently only the following notifiers are
 running under the lock:
 * ``NETDEV_CHANGE``
+* ``NETDEV_CHANGENAME``
 * ``NETDEV_REGISTER``
 * ``NETDEV_UP``
 
diff --git a/net/core/lock_debug.c b/net/core/lock_debug.c
index 14fd8fcdcd56..8a81c5430705 100644
--- a/net/core/lock_debug.c
+++ b/net/core/lock_debug.c
@@ -65,6 +65,7 @@ int netdev_debug_event(struct notifier_block *nb, unsigned long event,
 		break;
 
 	case NETDEV_CHANGENAME:
+		netdev_assert_locked_ops(dev);
 		ASSERT_RTNL_NET(net);
 		break;
 	}
-- 
2.54.0


  parent reply	other threads:[~2026-06-03  1:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  1:28 [PATCH net-next v2 00/11] net: ethtool: make sure __ethtool_get_link_ksettings() is ops-locked Jakub Kicinski
2026-06-03  1:28 ` [PATCH net-next v2 01/11] net: rename netdev_ops_assert_locked() Jakub Kicinski
2026-06-03  7:29   ` Nicolai Buchwitz
2026-06-03 11:15   ` Jakub Sitnicki
2026-06-03 17:05   ` Stanislav Fomichev
2026-06-03  1:28 ` [PATCH net-next v2 02/11] net: ethtool: cmis_cdb: hold instance lock for ops locked devices Jakub Kicinski
2026-06-03 17:06   ` Stanislav Fomichev
2026-06-03  1:28 ` Jakub Kicinski [this message]
2026-06-03 12:47   ` [PATCH net-next v2 03/11] net: document NETDEV_CHANGENAME as ops locked Jakub Sitnicki
2026-06-03 17:06   ` Stanislav Fomichev
2026-06-03  1:28 ` [PATCH net-next v2 04/11] net: ethtool: add netif_get_link_ksettings() for correct ops-locked use Jakub Kicinski
2026-06-03  6:40   ` Maxime Chevallier
2026-06-03 17:06   ` Stanislav Fomichev
2026-06-03  1:28 ` [PATCH net-next v2 05/11] net: bonding: don't recurse on the slave's netdev ops lock Jakub Kicinski
2026-06-03  7:20   ` Nicolai Buchwitz
2026-06-03  1:28 ` [PATCH net-next v2 06/11] net: team: don't recurse on the port's " Jakub Kicinski
2026-06-03  1:28 ` [PATCH net-next v2 07/11] net: bridge: " Jakub Kicinski
2026-06-03  7:16   ` Nicolai Buchwitz
2026-06-03  7:54   ` Nikolay Aleksandrov
2026-06-03 13:28   ` Ido Schimmel
2026-06-03  1:28 ` [PATCH net-next v2 08/11] net: sched: don't recurse on the netdev ops lock in qdiscs Jakub Kicinski
2026-06-04 23:38   ` Vinicius Costa Gomes
2026-06-03  1:28 ` [PATCH net-next v2 09/11] leds: trigger: netdev: don't recurse on the netdev ops lock Jakub Kicinski
2026-06-03  1:28 ` [PATCH net-next v2 10/11] scsi: fcoe: don't recurse on the netdev's " Jakub Kicinski
2026-06-03  1:28 ` [PATCH net-next v2 11/11] net: ethtool: make sure __ethtool_get_link_ksettings() is ops-locked Jakub Kicinski
2026-06-03  7:18   ` Nicolai Buchwitz
2026-06-03 17:06   ` Stanislav Fomichev
2026-06-04 21:30 ` [PATCH net-next v2 00/11] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603012840.2254293-4-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hare@suse.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jakub@cloudflare.com \
    --cc=jhasan@marvell.com \
    --cc=jhs@mojatatu.com \
    --cc=jv@jvosburgh.net \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=michael.chan@broadcom.com \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavel@kernel.org \
    --cc=razor@blackwall.org \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.