From: Ido Schimmel <idosch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jakub@cloudflare.com, maxime.chevallier@bootlin.com,
nb@tipi-net.de, lee@kernel.org, linux-leds@vger.kernel.org,
pavel@kernel.org, jv@jvosburgh.net, michael.chan@broadcom.com,
jhs@mojatatu.com, vinicius.gomes@intel.com, razor@blackwall.org,
hare@suse.de, jhasan@marvell.com, danieller@nvidia.com
Subject: Re: [PATCH net-next v2 07/11] net: bridge: don't recurse on the port's netdev ops lock
Date: Wed, 3 Jun 2026 16:28:03 +0300 [thread overview]
Message-ID: <20260603132803.GA645269@shredder> (raw)
In-Reply-To: <20260603012840.2254293-8-kuba@kernel.org>
On Tue, Jun 02, 2026 at 06:28:36PM -0700, Jakub Kicinski wrote:
> port_cost() calls __ethtool_get_link_ksettings() on the port device,
> which will soon take the port's ops lock. br_port_carrier_check()
> is reached via the NETDEV_CHANGE notifier from linkwatch, which
> already holds the port's ops lock, so the call would deadlock.
>
> Make port_cost() expect the port's ops lock held and switch to
> netif_get_link_ksettings(). The only other caller is new_nbp(),
> make sure it takes the lock explicitly.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2026-06-03 13:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 1:28 [PATCH net-next v2 00/11] net: ethtool: make sure __ethtool_get_link_ksettings() is ops-locked Jakub Kicinski
2026-06-03 1:28 ` [PATCH net-next v2 01/11] net: rename netdev_ops_assert_locked() Jakub Kicinski
2026-06-03 7:29 ` Nicolai Buchwitz
2026-06-03 11:15 ` Jakub Sitnicki
2026-06-03 17:05 ` Stanislav Fomichev
2026-06-03 1:28 ` [PATCH net-next v2 02/11] net: ethtool: cmis_cdb: hold instance lock for ops locked devices Jakub Kicinski
2026-06-03 17:06 ` Stanislav Fomichev
2026-06-03 1:28 ` [PATCH net-next v2 03/11] net: document NETDEV_CHANGENAME as ops locked Jakub Kicinski
2026-06-03 12:47 ` Jakub Sitnicki
2026-06-03 17:06 ` Stanislav Fomichev
2026-06-03 1:28 ` [PATCH net-next v2 04/11] net: ethtool: add netif_get_link_ksettings() for correct ops-locked use Jakub Kicinski
2026-06-03 6:40 ` Maxime Chevallier
2026-06-03 17:06 ` Stanislav Fomichev
2026-06-03 1:28 ` [PATCH net-next v2 05/11] net: bonding: don't recurse on the slave's netdev ops lock Jakub Kicinski
2026-06-03 7:20 ` Nicolai Buchwitz
2026-06-03 1:28 ` [PATCH net-next v2 06/11] net: team: don't recurse on the port's " Jakub Kicinski
2026-06-03 1:28 ` [PATCH net-next v2 07/11] net: bridge: " Jakub Kicinski
2026-06-03 7:16 ` Nicolai Buchwitz
2026-06-03 7:54 ` Nikolay Aleksandrov
2026-06-03 13:28 ` Ido Schimmel [this message]
2026-06-03 1:28 ` [PATCH net-next v2 08/11] net: sched: don't recurse on the netdev ops lock in qdiscs Jakub Kicinski
2026-06-04 23:38 ` Vinicius Costa Gomes
2026-06-03 1:28 ` [PATCH net-next v2 09/11] leds: trigger: netdev: don't recurse on the netdev ops lock Jakub Kicinski
2026-06-03 1:28 ` [PATCH net-next v2 10/11] scsi: fcoe: don't recurse on the netdev's " Jakub Kicinski
2026-06-03 1:28 ` [PATCH net-next v2 11/11] net: ethtool: make sure __ethtool_get_link_ksettings() is ops-locked Jakub Kicinski
2026-06-03 7:18 ` Nicolai Buchwitz
2026-06-03 17:06 ` Stanislav Fomichev
2026-06-04 21:30 ` [PATCH net-next v2 00/11] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603132803.GA645269@shredder \
--to=idosch@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hare@suse.de \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=jhasan@marvell.com \
--cc=jhs@mojatatu.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavel@kernel.org \
--cc=razor@blackwall.org \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.