All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: panel-orientation-quirks: Add HUION Kamvas Studio 16
@ 2026-06-07 11:31 Tyron Govender
  2026-06-07 11:36 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Tyron Govender @ 2026-06-07 11:31 UTC (permalink / raw)
  To: dri-devel
  Cc: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
	linux-kernel, Tyron Govender

Signed-off-by: Tyron Govender <dev@tyrongovender.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3a218fb59..85203b140 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -364,6 +364,15 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
 		},
 		.driver_data = (void *)&lcd1080x1920_rightside_up,
+	}, {	/*
+	 * HUION Kamvas Studio 16
+	 * DMI has "Kavmas" spelling error, matched intentionally here
+	 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HUION"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Kavmas Studio 16"),
+		},
+		.driver_data = (void *)&lcd2560x1440_bottom_up,
 	}, {	/* I.T.Works TW891 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
-- 
2.54.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm: panel-orientation-quirks: Add HUION Kamvas Studio 16
  2026-06-07 11:31 [PATCH] drm: panel-orientation-quirks: Add HUION Kamvas Studio 16 Tyron Govender
@ 2026-06-07 11:36 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-06-07 11:36 UTC (permalink / raw)
  To: Tyron Govender; +Cc: dri-devel

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undeclared identifier `lcd2560x1440_bottom_up` causing a build failure.
--

commit 532668bae9bf64a960a61fb91c8692d35f08f8e0
Author: Tyron Govender <dev@tyrongovender.com>

drm: panel-orientation-quirks: Add HUION Kamvas Studio 16

This commit adds a panel orientation quirk for the HUION Kamvas Studio 16.
It intentionally matches a spelling error in the DMI product name and
maps it to a bottom-up orientation for its 2560x1440 display.

> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3a218fb592cef..85203b1400095 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
[ ... ]
> @@ -364,6 +364,15 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
>  		},
>  		.driver_data = (void *)&lcd1080x1920_rightside_up,
> +	}, {	/*
> +	 * HUION Kamvas Studio 16
> +	 * DMI has "Kavmas" spelling error, matched intentionally here
> +	 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HUION"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Kavmas Studio 16"),
> +		},
> +		.driver_data = (void *)&lcd2560x1440_bottom_up,

[Severity: Low]
Does this cause a build failure? The patch references lcd2560x1440_bottom_up
here, but it appears the struct was never defined or declared.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260607113147.55507-1-dev@tyrongovender.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-07 11:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-07 11:31 [PATCH] drm: panel-orientation-quirks: Add HUION Kamvas Studio 16 Tyron Govender
2026-06-07 11:36 ` sashiko-bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.