All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Bin Meng <bmeng.cn@gmail.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Sughosh Ganu <sughosh.ganu@arm.com>
Subject: Re: [PATCH 3/5] x86: edison: Align U-Boot via binman to fix the boot
Date: Sun, 7 Jun 2026 17:47:26 -0600	[thread overview]
Message-ID: <20260607234726.GF382693@bill-the-cat> (raw)
In-Reply-To: <20260607230519.3022520-4-sjg@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Sun, Jun 07, 2026 at 05:05:12PM -0600, Simon Glass wrote:

> The mask ROM loads the OS image to 0x01100000 but enters it at
> 0x01101000, so U-Boot must sit 0x1000 (4KB) into the loaded image. This
> was arranged by board/intel/edison/config.mk, which prepended 4096 zero
> bytes to u-boot.bin through an 'INPUTS-y += u-boot-align.bin' rule whose
> recipe moved its output back over u-boot.bin.
> 
> Commit bd3f9ee679b4 ("kbuild: Bump the build system to 6.1") stopped
> that rule from running, so u-boot.bin no longer gains the 4KB prefix.
> The mask ROM then jumps 4KB into U-Boot's code and the board never
> starts, sitting in BootROM download mode (DnX) and cycling.
> 
> Since the Edison image is assembled by binman, provide the gap there
> instead: pad with a 'fill' of 4096 zero bytes ahead of the u-boot entry.
> Drop the now-redundant alignment hack from the board config.mk.
> 
> Fixes: bd3f9ee679b4 ("kbuild: Bump the build system to 6.1")
> Signed-off-by: Simon Glass <sjg@chromium.org>

That's an unintentional behavior change we should understand why
happened, and then do whatever needs to be done to fix it, so that other
platforms that might have been in a similar spot can also be fixed.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-06-07 23:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-07 23:05 [PATCH 0/5] edison: Fix mainline boot and convert the image to binman Simon Glass
2026-06-07 23:05 ` [PATCH 1/5] binman: Add an entry type for the Intel OSIP header Simon Glass
2026-06-08  8:22   ` Andy Shevchenko
2026-06-07 23:05 ` [PATCH 2/5] edison: Widen the DFU auto-probe window for flashing U-Boot Simon Glass
2026-06-08  8:24   ` Andy Shevchenko
2026-06-07 23:05 ` [PATCH 3/5] x86: edison: Align U-Boot via binman to fix the boot Simon Glass
2026-06-07 23:47   ` Tom Rini [this message]
2026-06-08  8:29     ` Andy Shevchenko
2026-06-08 14:00       ` Tom Rini
2026-06-13 13:05         ` Simon Glass
2026-06-08  7:47   ` Ilias Apalodimas
2026-06-08  8:27   ` Andy Shevchenko
2026-06-07 23:05 ` [PATCH 4/5] CI: Add an sjg-lab job for the Intel Edison Simon Glass
2026-06-07 23:05 ` [PATCH 5/5] doc: edison: Rewrite the update instructions Simon Glass
2026-06-08  9:34   ` Andy Shevchenko
2026-06-08  8:31 ` [PATCH 0/5] edison: Fix mainline boot and convert the image to binman Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260607234726.GF382693@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bmeng.cn@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.