Re: [PATCH v3 3/3] ARM: dts: ti: Add specific compatibles for SCM conf nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete refactoring: Several SCM conf nodes still retain a standalone 'syscon' compatible string.
--

commit f27db69296633e59ec29af047a99e08ea07397ae
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

ARM: dts: ti: Add specific compatibles for SCM conf nodes

The commit adds specific compatible strings to "syscon" and "simple-bus"
nodes in TI OMAP device trees. This addresses device tree binding
requirements that "syscon" must come with a specific compatible, and also
resolves contradictions when used with "simple-bus".

> diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> index c8d325b0f57b2..9df7648c4b793 100644
> --- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi
> @@ -64,7 +64,7 @@ scm: scm@0 {
>  				ranges = <0 0 0x2000>;
>  
>  				scm_conf: scm_conf@0 {
> -					compatible = "syscon", "simple-bus";
> +					compatible = "ti,dra7-scm-conf", "syscon", "simple-bus";
>  					reg = <0x0 0x1400>;
>  					#address-cells = <1>;
>  					#size-cells = <1>;

[Severity: Medium]
Does this patch miss other standalone "syscon" nodes in the updated files?

In arch/arm/boot/dts/ti/omap/dra7-l4.dtsi, there are other SCM conf nodes
that still only have compatible = "syscon", such as scm_conf1@1c04:

				scm_conf1: scm_conf@1c04 {
					compatible = "syscon";
					reg = <0x1c04 0x0020>;

and scm_wkup@0:

			scm_wkup: scm_conf@0 {
				compatible = "syscon";
				reg = <0 0x1000>;

[ ... ]

> diff --git a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
> index 4c78a0b28fab3..c1afc49f456cf 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi
> @@ -681,7 +681,7 @@ omap4_pmx_core: pinmux@40 {
>  			};
>  
>  			omap4_padconf_global: omap4_padconf_global@5a0 {
> -				compatible = "syscon",
> +				compatible = "ti,omap4-sysc-padconf-global", "syscon",
>  					     "simple-bus";
>  				reg = <0x5a0 0x170>;
>  				#address-cells = <1>;

[Severity: Medium]
Similarly, arch/arm/boot/dts/ti/omap/omap4-l4.dtsi appears to retain
a standalone "syscon" compatible in its scm_conf@0 node:

				scm_conf: scm_conf@0 {
					compatible = "syscon";
					reg = <0x0 0x800>;

This same pattern of skipped nodes appears in
arch/arm/boot/dts/ti/omap/omap5-l4.dtsi (scm_conf@0) and the sibling file
arch/arm/boot/dts/ti/omap/omap2420.dtsi (scm_conf@270).

Should these nodes also be updated to fully comply with the
writing-bindings.rst requirements?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260608-n-dt-bindings-simple-bus-syscon-v3-0-4eba9ec1212a@oss.qualcomm.com?part=3