Re: [PATCH v3 1/3] dt-bindings: mfd: syscon: Disallow simple-bus with syscon

[Rob Herring <robh@kernel.org>]

On Tue, Jun 09, 2026 at 05:36:30PM +0100, Conor Dooley wrote:
> On Mon, Jun 08, 2026 at 08:54:05PM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Medium] The patch introduces several new compatible strings (e.g., `ti,am3352-scm-conf`) to the exception list without documenting them in any valid dt-binding schema. This causes a bisectability breakage in `dtbs_check` during the series and leaves permanent 'undocumented compatible' warnings at the end of the series.
> > --
> > 
> > commit 0cddec624a3b6ba2f0c447b95621f32101d2e31f
> > Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > 
> > dt-bindings: mfd: syscon: Disallow simple-bus with syscon
> > 
> > This commit adds a schema to disallow the combination of syscon and
> > simple-bus compatibles. It includes an exception list for legacy
> > configurations that currently rely on this pattern.
> > 
> > > diff --git a/Documentation/devicetree/bindings/mfd/syscon-common.yaml b/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> > > index 14a08e7bc8bdd..2d5eef5add544 100644
> > > --- a/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/syscon-common.yaml
> > [ ... ]
> > > @@ -52,11 +53,44 @@ allOf:
> > >            contains:
> > >              const: simple-mfd
> > >      then:
> > > +      # Always require a specific compatible for syscon with simple-mfd
> > >        properties:
> > >          compatible:
> > >            minItems: 3
> > >            maxItems: 5
> > >  
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            const: simple-bus
> > > +    then:
> > > +      # simple-bus conflicts with syscon - if a device is a system controller
> > > +      # with miscellaneous registers, then it has at least one dedicated
> > > +      # function thus it is not a simple bus. Allow existing exceptions.
> > > +      if:
> > > +        properties:
> > > +          compatible:
> > > +            not:
> > > +              contains:
> > > +                # This list CANNOT grow
> > 
> > [Severity: Medium]
> > Will this break bisectability for dtbs_check? Since the DTS files are
> > updated later in the series, it seems like existing TI DTS files using syscon
> > and simple-bus without these new specific compatibles will fail validation
> > when this patch is applied.
> 
> Perhaps worth telling the sashiko people that transitory warnings like
> this aren't something we care about, especially since even the normal
> development process for devicetrees introduces validation issues in the
> platform maintainer branches.

I think that is on us to tweak the review prompts. There's already one 
for DT that none of us wrote. Though really I don't think that's all 
that maintainable. Really, IMO sashiko itself should be able to 
incorporate feedback like any other reviewer/developer.

Rob