From: Jakub Kicinski <kuba@kernel.org>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"moderated list:CAKE QDISC" <cake@lists.bufferbloat.net>,
"open list:TC subsystem" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length
Date: Tue, 9 Jun 2026 18:46:12 -0700 [thread overview]
Message-ID: <20260609184612.254a8000@kernel.org> (raw)
In-Reply-To: <CAE+C+DYpYjQoSsr3PsQ2pN5hf9+u0CbA=JwJ-2aR9Oz1GDDNrg@mail.gmail.com>
On Tue, 9 Jun 2026 20:55:35 -0400 Samuel Moelius wrote:
> On Tue, Jun 9, 2026 at 8:45 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote:
> > > CAKE accepts overhead values that can make adjusted packet length
> > > arithmetic underflow. A negative effective length can wrap through
> > > unsigned arithmetic and become a large value.
> >
> > Sorry, why are you posting more patches? You were told to stop
> > yesterday. And you received an email which said:
> >
> > Here are a few ground rules which are frequently broken by newcomers:
> >
> > - You must wait at least 24 hours before posting a new version to give
> > reviewers time to respond. This is a hard rule, no matter what your
> > reason to repost is.
> >
> > - Each new version of your series should be a fresh / separate thread
> > Add a https://lore.kernel.org/.. link to the previous version to
> > the cover letter or changelog, instead of threading the submissions.
> >
> > - Until you gain experience submit one of two patches at a time,
> > do not send multiple changes at once until some of your changes
> > were accepted. This avoids reviewers having to provide the same
> > feedback on multiple patches.
> >
> > - Avoid changing the subject of the changes or cover letter unless
> > necessary, it breaks our patch tracking.
> >
> > - If you're submitting changes for issues discovered using automated
> > tools - commit message should explain the discovery and testing
> > process (for drivers explicitly mention that you don't have access
> > to the device, it's not a blocker).
> >
> >
> > You broke at least 2 of these already.
> >
> > If you keep ignoring direct maintainer feedback you will be banned.
>
> I'm sorry for my misunderstanding. When should I resume submitting patches?
Please wait until your outstanding submissions get reviewed, here is
the patch review queue for netdev filtered down to your email:
https://patchwork.kernel.org/project/netdevbpf/list/?submitter=222403
Once that's empty you can resume but again please try to go slow.
4 patches under review at a time, start from the most impactful ones.
After you get >20 patches accepted (in networking specifically!) you
can open up the faucet a bit and go to 10 outstanding patches.
next prev parent reply other threads:[~2026-06-10 1:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 23:29 [PATCH net v2] net/sched: cake: reject overhead values that underflow length Samuel Moelius
2026-06-10 0:45 ` Jakub Kicinski
2026-06-10 0:55 ` Samuel Moelius
2026-06-10 1:46 ` Jakub Kicinski [this message]
2026-06-10 8:06 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609184612.254a8000@kernel.org \
--to=kuba@kernel.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sam.moelius@trailofbits.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.