Re: [PATCH v2 2/2] iio: pressure: ms5637: Add variant specific temperature compensation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Explicit cast to 64-bit in modulo operation causes build failure on 32-bit architectures.
--

commit 5b2cfee8f94f3621de42a9388dafb2dae478fda9
Author: Louis Adamian <adamianlouis@gmail.com>

iio: pressure: ms5637: Add variant specific temperature compensation

This commit adds variant-specific temperature compensation and pressure
scaling for ms5637, ms5803, and ms5837 sensors. It extracts the compensation
constants into a per-device structure to handle differences across the
sensor variants.

> diff --git a/drivers/iio/pressure/ms5637.c b/drivers/iio/pressure/ms5637.c
> index 03945a4fc7188..36bda9694b4c4 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
[ ... ]
> @@ -73,8 +74,10 @@ static int ms5637_read_raw(struct iio_dev *indio_dev,
>  
>  			return IIO_VAL_INT;
>  		case IIO_PRESSURE:	/* in kPa */
> -			*val = pressure / 1000;
> -			*val2 = (pressure % 1000) * 1000;
> +			*val = pressure / dev_data->comp_consts->press_scale;
> +			*val2 = (pressure %
> +				 (s64)dev_data->comp_consts->press_scale) *
> +				(1000000 / dev_data->comp_consts->press_scale);

[Severity: Low]
Does casting this modulo divisor to a 64-bit integer cause a build failure
on 32-bit architectures?

Since pressure is an unsigned int and press_scale is a u32, the s64 cast
promotes the modulo operation to 64-bit. On 32-bit platforms, this typically
results in an undefined reference to __moddi3 because the kernel does not
link libgcc.

Since the modulo result easily fits within a 32-bit integer, can this s64
cast be removed to prevent breaking 32-bit compile targets?

>  
>  			return IIO_VAL_INT_PLUS_MICRO;
>  		default:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610020458.104818-1-adamianlouis@gmail.com?part=2